refactor: pass max buffer to binarystylesheet

Author: Danielku15

packages/alphatab/src/generated/CoreSettingsJson.ts

@@ -174,15 +174,4 @@ export interface CoreSettingsJson {
      * ```
      */
     includeNoteBounds?: boolean;
-    /**
-     * This setting controls the escape hatch for handling potentially malicous or corrupt
-     * input files. At selected spots in the codebase, we use this buffer size as maximum
-     * allowed sizes. e.g. during unzipping or decoding strings.
-     * This prevents resource exhaustion, especially when alphaTab is used on server side.
-     * Increase this buffer size if you need to handle very big files.
-     * @defaultValue `128000000`
-     * @category Core
-     * @since 1.9.0
-     */
-    maxDecodingBufferSize?: number;
 }

packages/alphatab/src/generated/CoreSettingsSerializer.ts

@@ -45,7 +45,6 @@ export class CoreSettingsSerializer {
         o.set("loglevel", obj.logLevel as number);
         o.set("useworkers", obj.useWorkers);
         o.set("includenotebounds", obj.includeNoteBounds);
-        o.set("maxdecodingbuffersize", obj.maxDecodingBufferSize);
         return o;
     }
     public static setProperty(obj: CoreSettings, property: string, v: unknown): boolean {
@@ -92,9 +91,6 @@ export class CoreSettingsSerializer {
             case "includenotebounds":
                 obj.includeNoteBounds = v! as boolean;
                 return true;
-            case "maxdecodingbuffersize":
-                obj.maxDecodingBufferSize = v! as number;
-                return true;
         }
         return false;
     }

packages/alphatab/src/generated/ImporterSettingsJson.ts

@@ -67,4 +67,15 @@ export interface ImporterSettingsJson {
      * ![Disabled](https://alphatab.net/img/reference/property/beattextaslyrics-disabled.png)
      */
     beatTextAsLyrics?: boolean;
+    /**
+     * This setting controls the escape hatch for handling potentially malicous or corrupt
+     * input files. At selected spots in the codebase, we use this buffer size as maximum
+     * allowed sizes. e.g. during unzipping or decoding strings.
+     * This prevents resource exhaustion, especially when alphaTab is used on server side.
+     * Increase this buffer size if you need to handle very big files.
+     * @defaultValue `128000000`
+     * @category Core
+     * @since 1.9.0
+     */
+    maxDecodingBufferSize?: number;
 }

packages/alphatab/src/generated/ImporterSettingsSerializer.ts

@@ -23,6 +23,7 @@ export class ImporterSettingsSerializer {
         o.set("encoding", obj.encoding);
         o.set("mergepartgroupsinmusicxml", obj.mergePartGroupsInMusicXml);
         o.set("beattextaslyrics", obj.beatTextAsLyrics);
+        o.set("maxdecodingbuffersize", obj.maxDecodingBufferSize);
         return o;
     }
     public static setProperty(obj: ImporterSettings, property: string, v: unknown): boolean {
@@ -36,6 +37,9 @@ export class ImporterSettingsSerializer {
             case "beattextaslyrics":
                 obj.beatTextAsLyrics = v! as boolean;
                 return true;
+            case "maxdecodingbuffersize":
+                obj.maxDecodingBufferSize = v! as number;
+                return true;
         }
         return false;
     }

packages/alphatab/src/importer/BinaryStylesheet.ts

@@ -76,18 +76,18 @@ export class BinaryStylesheet {
     private readonly _types: Map<string, DataType> = new Map();
     public readonly raw: Map<string, unknown> = new Map();
 
-    public constructor(data?: Uint8Array) {
+    public constructor(data?: Uint8Array, maxDecodingBufferSize: number = 0) {
         if (data) {
-            this._read(data);
+            this._read(data, maxDecodingBufferSize);
         }
     }
 
-    private _read(data: Uint8Array) {
+    private _read(data: Uint8Array, maxDecodingBufferSize: number) {
         // BinaryStylesheet apears to be big-endien
         const readable: ByteBuffer = ByteBuffer.fromBuffer(data);
         const entryCount: number = IOHelper.readInt32BE(readable);
         for (let i: number = 0; i < entryCount; i++) {
-            const key: string = GpBinaryHelpers.gpReadString(readable, readable.readByte(), 'utf-8');
+            const key: string = GpBinaryHelpers.gpReadString(readable, readable.readByte(), 'utf-8', maxDecodingBufferSize);
             const type: DataType = readable.readByte() as DataType;
             this._types.set(key, type);
             switch (type) {
@@ -104,7 +104,7 @@ export class BinaryStylesheet {
                     this.addValue(key, fvalue);
                     break;
                 case DataType.String:
-                    const s: string = GpBinaryHelpers.gpReadString(readable, IOHelper.readInt16BE(readable), 'utf-8');
+                    const s: string = GpBinaryHelpers.gpReadString(readable, IOHelper.readInt16BE(readable), 'utf-8', maxDecodingBufferSize);
                     this.addValue(key, s);
                     break;
                 case DataType.Point:

packages/alphatab/src/importer/Gp7To8Importer.ts

@@ -78,7 +78,7 @@ export class Gp7To8Importer extends ScoreImporter {
 
         if (binaryStylesheetData) {
             Logger.debug(this.name, 'Start Parsing BinaryStylesheet');
-            const stylesheet: BinaryStylesheet = new BinaryStylesheet(binaryStylesheetData);
+            const stylesheet: BinaryStylesheet = new BinaryStylesheet(binaryStylesheetData, this.settings.importer.maxDecodingBufferSize);
             stylesheet.apply(score);
             Logger.debug(this.name, 'BinaryStylesheet parsed');
         }

packages/alphatab/src/importer/GpxImporter.ts

@@ -69,7 +69,7 @@ export class GpxImporter extends ScoreImporter {
 
         if (binaryStylesheetData) {
             Logger.debug(this.name, 'Start Parsing BinaryStylesheet');
-            const binaryStylesheet: BinaryStylesheet = new BinaryStylesheet(binaryStylesheetData);
+            const binaryStylesheet: BinaryStylesheet = new BinaryStylesheet(binaryStylesheetData, this.settings.importer.maxDecodingBufferSize);
             binaryStylesheet.apply(score);
             Logger.debug(this.name, 'BinaryStylesheet parsed');
         }