Skip to content

Commit 52396ed

Browse files
committed
refactor(abstract-eth): delete mpc related classes
WIN-1021 BREAKING CHANGE: AbstractEthLikeMPCCoin and EthLikeMPCToken classes are removed as we have instead added a new class AbstractEthLikeNewCoins which will be having both multisig and MPC related methods TICKET: WIN-1021
1 parent 519fe47 commit 52396ed

7 files changed

Lines changed: 44 additions & 46 deletions

File tree

modules/abstract-eth/src/abstractEthLikeMPCCoin.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

modules/abstract-eth/src/ethLikeMPCToken.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

modules/abstract-eth/src/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
export * from './abstractEthLikeCoin';
22
export * from './ethLikeToken';
3-
export * from './abstractEthLikeMPCCoin';
4-
export * from './ethLikeMPCToken';
53
export * from './lib';
64
export * from './abstractEthLikeNewCoins';

modules/sdk-coin-arbeth/src/arbethToken.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
/**
22
* @prettier
33
*/
4-
import { EthLikeTokenConfig } from '@bitgo/statics';
4+
import { EthLikeTokenConfig, coins } from '@bitgo/statics';
55
import { BitGoBase, CoinConstructor, NamedCoinConstructor } from '@bitgo/sdk-core';
6-
import { CoinNames, EthLikeMPCToken } from '@bitgo/abstract-eth';
6+
import { CoinNames, EthLikeToken } from '@bitgo/abstract-eth';
77

8+
import { TransactionBuilder } from './lib';
89
export { EthLikeTokenConfig };
910

10-
export class ArbethToken extends EthLikeMPCToken {
11+
export class ArbethToken extends EthLikeToken {
1112
public readonly tokenConfig: EthLikeTokenConfig;
1213
static coinNames: CoinNames = {
1314
Mainnet: 'arbeth',
@@ -24,6 +25,10 @@ export class ArbethToken extends EthLikeMPCToken {
2425
return super.createTokenConstructors(ArbethToken.coinNames);
2526
}
2627

28+
protected getTransactionBuilder(): TransactionBuilder {
29+
return new TransactionBuilder(coins.get(this.getBaseChain()));
30+
}
31+
2732
getFullName(): string {
2833
return 'Arbeth Token';
2934
}

modules/sdk-coin-bsc/src/bsc.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import { BaseCoin, BitGoBase } from '@bitgo/sdk-core';
1+
import { BaseCoin, BitGoBase, MPCAlgorithm } from '@bitgo/sdk-core';
22
import { BaseCoin as StaticsBaseCoin, coins } from '@bitgo/statics';
3-
import { AbstractEthLikeMPCCoin } from '@bitgo/abstract-eth';
3+
import { AbstractEthLikeCoin } from '@bitgo/abstract-eth';
44
import { TransactionBuilder as EthTransactionBuilder } from '@bitgo/sdk-coin-eth';
55
import { TransactionBuilder } from './lib';
66

7-
export class Bsc extends AbstractEthLikeMPCCoin {
7+
export class Bsc extends AbstractEthLikeCoin {
88
protected constructor(bitgo: BitGoBase, staticsCoin?: Readonly<StaticsBaseCoin>) {
99
super(bitgo, staticsCoin);
1010
}
@@ -21,4 +21,14 @@ export class Bsc extends AbstractEthLikeMPCCoin {
2121
allowsAccountConsolidations(): boolean {
2222
return true;
2323
}
24+
25+
/** @inheritDoc */
26+
supportsTss(): boolean {
27+
return true;
28+
}
29+
30+
/** @inheritDoc */
31+
getMPCAlgorithm(): MPCAlgorithm {
32+
return 'ecdsa';
33+
}
2434
}

modules/sdk-coin-bsc/src/bscToken.ts

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22
* @prettier
33
*/
44

5-
import { EthLikeTokenConfig } from '@bitgo/statics';
6-
import { BitGoBase, CoinConstructor, NamedCoinConstructor } from '@bitgo/sdk-core';
7-
import { CoinNames, EthLikeMPCToken } from '@bitgo/abstract-eth';
5+
import { EthLikeTokenConfig, coins } from '@bitgo/statics';
6+
import { BitGoBase, CoinConstructor, NamedCoinConstructor, MPCAlgorithm } from '@bitgo/sdk-core';
7+
import { CoinNames, EthLikeToken } from '@bitgo/abstract-eth';
8+
import { TransactionBuilder } from './lib';
89

910
export { EthLikeTokenConfig };
1011

11-
export class BscToken extends EthLikeMPCToken {
12+
export class BscToken extends EthLikeToken {
1213
public readonly tokenConfig: EthLikeTokenConfig;
1314
static coinNames: CoinNames = {
1415
Mainnet: 'bsc',
@@ -25,6 +26,20 @@ export class BscToken extends EthLikeMPCToken {
2526
return super.createTokenConstructors(BscToken.coinNames);
2627
}
2728

29+
protected getTransactionBuilder(): TransactionBuilder {
30+
return new TransactionBuilder(coins.get(this.getBaseChain()));
31+
}
32+
33+
/** @inheritDoc */
34+
supportsTss(): boolean {
35+
return true;
36+
}
37+
38+
/** @inheritDoc */
39+
getMPCAlgorithm(): MPCAlgorithm {
40+
return 'ecdsa';
41+
}
42+
2843
getFullName(): string {
2944
return 'Bsc Token';
3045
}

modules/sdk-coin-bsc/src/lib/transactionBuilder.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,8 @@ export class TransactionBuilder extends EthTransactionBuilder {
2727
publicKey(key: string): void {
2828
this._sourceKeyPair = new KeyPair({ pub: key });
2929
}
30+
31+
protected getContractData(addresses: string[]): string {
32+
throw new Error('Method not implemented.');
33+
}
3034
}

0 commit comments

Comments
 (0)