fixup(notifications): drop trending_playlist from handle_trending

The trending playlist reward (challenge_id 'tp') is being removed as a
product feature, so handle_trending no longer needs to emit
`trending_playlist` notifications.

Scope: just this PR's trigger. PR #835's NewTrendingPlaylistProcessor +
'tp' catalog seed are still in place — harmless if the upstream feature
stays inactive, can be torn out separately if desired.

Changes:
- handle_trending.sql: drop the 'tp' case from the type switch, WHEN
  clause, and data_jsonb branch. Trigger now only handles 'tt' and
  'tut' (both tracks), so the entity_label variable goes away too.
- trending_test.go: remove TestTrendingPlaylist_EmitsNotification.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: raymondjacobson

ddl/functions/handle_trending.sql

@@ -1,14 +1,18 @@
 -- handle_trending
 --
--- Emits one of `trending`, `trending_underground`, or `trending_playlist`
--- when the trending challenge processor mints a user_challenges row for
--- challenge_id 'tt' / 'tut' / 'tp'. These are the "your track is
--- trending" notifications shown to the entity (track/playlist) owner.
+-- Emits a `trending` or `trending_underground` notification when the
+-- trending challenge processor mints a user_challenges row for
+-- challenge_id 'tt' / 'tut'. These are the "your track is trending"
+-- notifications shown to the track owner.
+--
+-- (Trending playlists — challenge_id 'tp' — were a product feature that
+-- has since been removed, so they're intentionally not handled here.
+-- handle_user_challenges.sql still excludes 'tp' from the
+-- claimable_reward path on line 14 for historical rows.)
 --
 -- Sibling of handle_user_challenges.sql which already emits the generic
--- `challenge_reward` notification for all challenge completions (and
--- skips the legacy `claimable_reward` for these three ids on line 14).
--- This trigger is the type-specific layer that matches apps'
+-- `challenge_reward` notification for all challenge completions. This
+-- trigger is the type-specific layer that matches apps'
 -- index_trending.py notifications.
 --
 -- Specifier shape from jobs/challenges/trending.go is "<week>:<rank>"
@@ -22,18 +26,16 @@ declare
   entity_id_int   bigint;
   notif_type      text;
   trend_type      text;
-  entity_label    text;
   ts_epoch        bigint;
   data_jsonb      jsonb;
 begin
-  if new.challenge_id not in ('tt', 'tut', 'tp') then
+  if new.challenge_id not in ('tt', 'tut') then
     return null;
   end if;
 
   case new.challenge_id
-    when 'tt'  then notif_type := 'trending';             trend_type := 'TRACKS';             entity_label := 'track_id';
-    when 'tut' then notif_type := 'trending_underground'; trend_type := 'UNDERGROUND_TRACKS'; entity_label := 'track_id';
-    when 'tp'  then notif_type := 'trending_playlist';    trend_type := 'PLAYLISTS';          entity_label := 'playlist_id';
+    when 'tt'  then notif_type := 'trending';             trend_type := 'TRACKS';
+    when 'tut' then notif_type := 'trending_underground'; trend_type := 'UNDERGROUND_TRACKS';
   end case;
 
   -- Specifier: "<YYYY-MM-DD>:<rank>"
@@ -69,21 +71,12 @@ begin
   -- the first insert — close enough to the recompute moment.
   ts_epoch := extract(epoch from new.completed_at)::bigint;
 
-  if new.challenge_id = 'tp' then
-    data_jsonb := jsonb_build_object(
-      'time_range',  'week',
-      'genre',       'all',
-      'rank',        rank_int,
-      'playlist_id', entity_id_int
-    );
-  else
-    data_jsonb := jsonb_build_object(
-      'time_range', 'week',
-      'genre',      'all',
-      'rank',       rank_int,
-      'track_id',   entity_id_int
-    );
-  end if;
+  data_jsonb := jsonb_build_object(
+    'time_range', 'week',
+    'genre',      'all',
+    'rank',       rank_int,
+    'track_id',   entity_id_int
+  );
 
   insert into notification
     (blocknumber, user_ids, timestamp, type, specifier, group_id, data)
@@ -96,7 +89,7 @@ begin
       entity_id_int::text,
       notif_type
         || ':time_range:week:genre:all:rank:' || rank_int
-        || ':' || entity_label || ':' || entity_id_int
+        || ':track_id:' || entity_id_int
         || ':timestamp:' || ts_epoch,
       data_jsonb
     )
@@ -119,7 +112,7 @@ do $$ begin
   -- fire AFTER INSERT triggers.
   create trigger on_trending_user_challenge
     after insert on user_challenges
-    for each row when (new.challenge_id in ('tt', 'tut', 'tp'))
+    for each row when (new.challenge_id in ('tt', 'tut'))
     execute procedure handle_trending();
 exception
   when others then null;

jobs/challenges/trending_test.go

@@ -156,51 +156,3 @@ func TestTrending_EmitsNotification(t *testing.T) {
 	assert.Contains(t, nGroupID, ":rank:1:track_id:")
 	assert.Contains(t, nGroupID, "trending:time_range:week:genre:all")
 }
-
-// TestTrendingPlaylist_EmitsNotification — handle_trending fans out a
-// `trending_playlist` notification with playlist_id (not track_id) in
-// the data payload and group_id.
-func TestTrendingPlaylist_EmitsNotification(t *testing.T) {
-	if time.Now().UTC().Weekday() != time.Friday {
-		t.Skip("trending processor only runs on Fridays UTC")
-	}
-	pool := withChallengesDB(t)
-	ctx := context.Background()
-	now := time.Now()
-
-	database.Seed(pool, database.FixtureMap{
-		"blocks": {{"blockhash": "blk_tpn", "number": 1}},
-		"users":  {{"user_id": 700, "wallet": "0x700"}},
-		"playlists": {{
-			"playlist_id":       7001,
-			"playlist_owner_id": 700,
-			"playlist_name":     "P",
-			"blocknumber":       1,
-			"created_at":        now,
-		}},
-	})
-
-	_, err := pool.Exec(ctx, `
-		INSERT INTO playlist_trending_scores (playlist_id, type, version, time_range, score, created_at)
-		VALUES (7001, 'PLAYLISTS', 'pnagD', 'week', 999.0, now())
-	`)
-	require.NoError(t, err)
-
-	runProcessor(t, pool, NewTrendingPlaylistProcessor())
-
-	var nGroupID string
-	var nData []byte
-	err = pool.QueryRow(ctx, `
-		SELECT group_id, data
-		FROM notification
-		WHERE type = 'trending_playlist' AND user_ids = ARRAY[700]
-	`).Scan(&nGroupID, &nData)
-	require.NoError(t, err, "expected trending_playlist notif")
-
-	var data map[string]any
-	require.NoError(t, json.Unmarshal(nData, &data))
-	assert.EqualValues(t, 7001, data["playlist_id"])
-	assert.NotContains(t, data, "track_id")
-	assert.Contains(t, nGroupID, ":playlist_id:7001:")
-	assert.Contains(t, nGroupID, "trending_playlist:time_range:week:genre:all")
-}