feat: allow smuggeling an exception in a ProblemInstance - #557
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Altinn.Authorization.ProblemDetails abstractions to allow attaching an Exception to a ProblemInstance while keeping ProblemInstance equality/hash semantics unchanged, and provides convenience APIs for converting/throwing problem instances as exceptions.
Changes:
- Add
Exception-carryingProblemInstance.Create(...)(andProblemDescriptor.Create(...)) overloads, plusProblemInstance.ToException()/Throw()helpers. - Update
ProblemInstanceExceptionto fall back to theProblemInstance-carried exception asInnerException. - Introduce
EqualityIgnoredOptional<T>so the attached exception is excluded from record equality/hash, and add a unit test verifying exception is ignored in equality.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Altinn.Authorization.ProblemDetails/test/ProblemDetails.Tests/ProblemInstanceTests.cs | Adds a regression test that ProblemInstance equality/hash ignore the attached exception. |
| src/Altinn.Authorization.ProblemDetails/src/ProblemDetails.Abstractions/ProblemInstance.cs | Adds exception-carrying factory overloads and stores exception in an equality-ignored wrapper. |
| src/Altinn.Authorization.ProblemDetails/src/ProblemDetails.Abstractions/EqualityIgnoredOptional.cs | New helper type used to exclude exception from record equality/hash. |
| src/Altinn.Authorization.ProblemDetails/src/ProblemDetails.Abstractions/ProblemInstanceException.cs | Uses problemInstance.Exception as InnerException fallback. |
| src/Altinn.Authorization.ProblemDetails/src/ProblemDetails.Abstractions/ProblemExtensions.cs | Adds Create(..., Exception) overloads and ProblemInstance extension members for ToException()/Throw(). |
| src/Altinn.Authorization.ProblemDetails/src/ProblemDetails.Abstractions/ValidationProblemInstance.cs | Updates base constructor call to pass exception: null. |
| src/Altinn.Authorization.ProblemDetails/src/ProblemDetails.Abstractions/MultipleProblemInstance.cs | Updates base constructor call to pass exception: null. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Alxandr
force-pushed
the
feat/problem-source
branch
from
April 24, 2026 11:27
0950082 to
6fd0bb7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The smuggeled exception is used when converting the ProblemInstance to an Exception
Alxandr
force-pushed
the
feat/problem-source
branch
from
April 24, 2026 12:01
6fd0bb7 to
a9c94a3
Compare
|
TheTechArch
approved these changes
Apr 24, 2026
This was referenced May 28, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.