Use const& and std::move to avoid copies

Mostly done automatically by Clang-Tidy.

Author: vkucera

Tutorials/PWGCF/EventPlane/src/qVectorstutorial.cxx

@@ -98,7 +98,7 @@ struct qVectorstutorial {
   }
 
   template <typename TrackType>
-  bool SelTrack(const TrackType track)
+  bool SelTrack(const TrackType& track)
   {
     if (track.pt() < cfgMinPt)
       return false;

Tutorials/PWGEM/Cocktail/plotLFCocktail.C

@@ -30,7 +30,7 @@ TString histLegends[nHists] = {
   "#phi#rightarrow#etae^{+}e^{-}, #phi#rightarrow#pi^{0}e^{+}e^{-}, "
   "#phi#rightarrowe^{+}e^{-}"};
 
-void loadHistos(TFile* file, TH1F* hists[], TString name_extra, int rebin,
+void loadHistos(TFile* file, TH1F* hists[], const TString& name_extra, int rebin,
                 int nEvents)
 {
   for (int i = 0; i < nHists; i++) {
@@ -42,7 +42,7 @@ void loadHistos(TFile* file, TH1F* hists[], TString name_extra, int rebin,
   }
 }
 
-void plotLFCocktail(TString filename = "AnalysisResults.root", int rebin = 1)
+void plotLFCocktail(const TString& filename = "AnalysisResults.root", int rebin = 1)
 {
 
   TFile* file = TFile::Open(filename.Data());

Tutorials/PWGLF/Resonance/resonancesCombine.cxx

@@ -93,7 +93,7 @@ struct ResonanceCombine {
   }
 
   template <typename TrackType>
-  bool trackCut(const TrackType track)
+  bool trackCut(const TrackType& track)
   {
     if (std::abs(track.pt()) < cMinPtcut)
       return false;

Tutorials/PWGLF/Resonance/resonancesMicrotrack.cxx

@@ -90,7 +90,7 @@ struct ResonancesMicrotrack {
   }
 
   template <bool IsResoMicrotrack, typename TrackType>
-  bool trackCut(const TrackType track)
+  bool trackCut(const TrackType& track)
   {
     if constexpr (!IsResoMicrotrack) {
       if (std::abs(track.pt()) < cMinPtcut)

Tutorials/PWGLF/Resonance/resonances_step0.cxx

@@ -47,7 +47,7 @@ struct resonances_tutorial {
 
   // Track selection
   template <typename TrackType>
-  bool trackCut(const TrackType track)
+  bool trackCut(const TrackType& track)
   {
     // basic track cuts
     if (std::abs(track.pt()) < cMinPtcut)
@@ -60,7 +60,7 @@ struct resonances_tutorial {
   template <bool IsMC, bool IsMix, typename CollisionType, typename TracksType>
   void fillHistograms(const CollisionType& /*collision*/, const TracksType& dTracks1, const TracksType& /*dTracks2*/)
   {
-    for (auto track1 : dTracks1) { // loop over all dTracks1
+    for (const auto& track1 : dTracks1) { // loop over all dTracks1
       if (!trackCut(track1))
         continue; // track selection and PID selection
       histos.fill(HIST("hEta"), track1.eta());

Tutorials/PWGLF/Resonance/resonances_step1.cxx

@@ -84,7 +84,7 @@ struct resonances_tutorial {
 
   // Track selection
   template <typename TrackType>
-  bool trackCut(const TrackType track)
+  bool trackCut(const TrackType& track)
   {
     // basic track cuts
     if (std::abs(track.pt()) < cMinPtcut)
@@ -121,7 +121,7 @@ struct resonances_tutorial {
   void fillHistograms(const CollisionType& collision, const TracksType& dTracks1, const TracksType& dTracks2)
   {
     auto multiplicity = collision.cent();
-    for (auto track1 : dTracks1) { // loop over all dTracks1
+    for (const auto& track1 : dTracks1) { // loop over all dTracks1
       if (!trackCut(track1) || !selectionPID(track1)) {
         continue; // track selection and PID selection
       }
@@ -133,7 +133,7 @@ struct resonances_tutorial {
       if (track1.hasTOF()) {
         histos.fill(HIST("hNsigmaKaonTOF"), track1.tofNSigmaKa());
       }
-      for (auto track2 : dTracks2) { // loop over all dTracks2
+      for (const auto& track2 : dTracks2) { // loop over all dTracks2
         if (!trackCut(track2) || !selectionPID(track2)) {
           continue; // track selection and PID selection
         }

Tutorials/PWGLF/Resonance/resonances_step2.cxx

@@ -96,7 +96,7 @@ struct resonances_tutorial {
 
   // Track selection
   template <typename TrackType>
-  bool trackCut(const TrackType track)
+  bool trackCut(const TrackType& track)
   {
     // basic track cuts
     if (std::abs(track.pt()) < cMinPtcut)
@@ -133,7 +133,7 @@ struct resonances_tutorial {
   void fillHistograms(const CollisionType& collision, const TracksType& dTracks1, const TracksType& dTracks2)
   {
     auto multiplicity = collision.cent();
-    for (auto track1 : dTracks1) { // loop over all dTracks1
+    for (const auto& track1 : dTracks1) { // loop over all dTracks1
       if (!trackCut(track1) || !selectionPID(track1)) {
         continue; // track selection and PID selection
       }
@@ -145,7 +145,7 @@ struct resonances_tutorial {
       if (track1.hasTOF()) {
         histos.fill(HIST("hNsigmaKaonTOF"), track1.tofNSigmaKa());
       }
-      for (auto track2 : dTracks2) { // loop over all dTracks2
+      for (const auto& track2 : dTracks2) { // loop over all dTracks2
         if (!trackCut(track2) || !selectionPID(track2)) {
           continue; // track selection and PID selection
         }

Tutorials/PWGLF/Resonance/resonances_step3.cxx

@@ -47,7 +47,7 @@ struct resonances_tutorial {
 
   // MC particle selection
   template <typename ParticleType>
-  bool ptCut(const ParticleType resoParents)
+  bool ptCut(const ParticleType& resoParents)
   {
     // basic pt cuts
     if (std::abs(resoParents.pt()) < cMinPtcut)
@@ -60,7 +60,7 @@ struct resonances_tutorial {
   template <typename CollisionType, typename ParticleType>
   void fillHistograms(const CollisionType& /*collision*/, const ParticleType& resoParents)
   {
-    for (auto part : resoParents) { // loop over all resoParents
+    for (const auto& part : resoParents) { // loop over all resoParents
       if (!ptCut(part))
         continue; // pt selection
 

Tutorials/PWGLF/Resonance/resonances_step4.cxx

@@ -63,7 +63,7 @@ struct resonances_tutorial {
 
   // MC particle selection
   template <typename ParticleType>
-  bool ptCut(const ParticleType resoParents)
+  bool ptCut(const ParticleType& resoParents)
   {
     // basic pt cuts
     if (std::abs(resoParents.pt()) < cMinPtcut)

Tutorials/PWGLF/Resonance/resonances_step5.cxx

@@ -80,7 +80,7 @@ struct resonances_tutorial {
 
   // Track selection
   template <typename TrackType>
-  bool trackCut(const TrackType track)
+  bool trackCut(const TrackType& track)
   {
     // basic track cuts
     if (std::abs(track.pt()) < cMinPtcut)
@@ -113,7 +113,7 @@ struct resonances_tutorial {
   template <typename CollisionType, typename TracksType>
   void fillHistograms(const CollisionType& /* collision */, const TracksType& dTracks)
   {
-    for (auto track : dTracks) { // loop over all dTracks
+    for (const auto& track : dTracks) { // loop over all dTracks
       if (!trackCut(track) || !selectionPID(track)) {
         continue; // track selection and PID selection
       }