Fix: Fixed some problems

Author: Nino van Galen

lib/domain/entities/Attachment.js

@@ -56,10 +56,17 @@ const readAttachment = async (request, response, next) => {
         return;
     }
 
-    const { attachment, errors } = await new GetAttachmentUseCase()
+    const { attachment } = await new GetAttachmentUseCase()
         .execute(value);
-    if (errors) {
-        response.status(400).json(errors);
+    if (!attachment) {
+        response.status(400).json({
+            errors: [
+                {
+                    status: '404',
+                    title: `Attachment with this id (${request.params.attachmentId}) could not be found`,
+                },
+            ],
+        });
         return;
     }
     response.status(200).sendFile(attachment.path);

lib/server/controllers/attachments.controller.js

@@ -144,15 +144,15 @@ const getAttachment = async (request, response, next) => {
         return;
     }
 
-    const { file, error } = await new GetLogAttachmentUseCase()
+    const { result, error } = await new GetLogAttachmentUseCase()
         .execute(dto);
 
     if (error) {
         response.status(Number(error.status)).json({ errors: [error] });
         return;
     }
 
-    response.status(200).sendFile(file.path);
+    response.status(200).sendFile(result.path);
 };
 
 /**

lib/server/controllers/logs.controller.js

@@ -33,23 +33,13 @@ class GetAttachment {
      */
     async execute(dto) {
         const queryBuilder = new QueryBuilder();
-        const { params, query = {} } = dto;
+        const { params } = dto;
         const { id } = params;
-        const { mimetype } = query;
 
         queryBuilder.where('id').is(id);
 
-        if (query) {
-            if (mimetype) {
-                if (mimetype.includes('/')) {
-                    queryBuilder.where('mime_type').is(mimetype);
-                } else {
-                    queryBuilder.where('mime_type').startsWith(mimetype);
-                }
-            }
-        }
-
-        return TransactionHelper.provide(() => AttachmentRepository.findOne(queryBuilder));
+        return TransactionHelper
+            .provide(async () => ({ attachment: await AttachmentRepository.findOne(queryBuilder) }));
     }
 }
 

lib/usecases/attachment/GetAttachmentUseCase.js

@@ -50,7 +50,6 @@ class GetLogAttachmentUseCase {
         }
 
         const result = await TransactionHelper.provide(() => AttachmentRepository.findOne(queryBuilder));
-
         if (!result) {
             return {
                 error: {