Suppress SpotBugs exposure warnings (#231)

Author: AlexProgrammerDE

bungee/src/main/java/net/pistonmaster/pistonqueue/bungee/PistonQueueBungee.java

@@ -19,6 +19,7 @@
  */
 package net.pistonmaster.pistonqueue.bungee;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import lombok.Getter;
 import net.md_5.bungee.api.ChatColor;
 import net.md_5.bungee.api.ChatMessageType;
@@ -158,6 +159,10 @@ public Path getDataDirectory() {
   }
 
   @Override
+  @SuppressFBWarnings(
+    value = "EI_EXPOSE_REP",
+    justification = "Configuration is intentionally shared and mutated via copyFrom to keep references in sync"
+  )
   public Config getConfiguration() {
     return configuration;
   }

shared/src/main/java/net/pistonmaster/pistonqueue/shared/config/Config.java

@@ -23,7 +23,6 @@
 import de.exlll.configlib.Configuration;
 import de.exlll.configlib.Ignore;
 import de.exlll.configlib.PostProcess;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import net.pistonmaster.pistonqueue.shared.queue.BanType;
 import net.pistonmaster.pistonqueue.shared.queue.QueueGroup;
 import net.pistonmaster.pistonqueue.shared.queue.QueueType;
@@ -41,10 +40,6 @@
 import java.util.Optional;
 
 @Configuration
-@SuppressFBWarnings(
-  value = "PA_PUBLIC_PRIMITIVE_ATTRIBUTE",
-  justification = "Fields intentionally exposed through getters for ConfigLib serialization compatibility"
-)
 public final class Config {
   public static final int CURRENT_VERSION = 2;
 

shared/src/main/java/net/pistonmaster/pistonqueue/shared/hooks/PistonMOTDPlaceholder.java

@@ -19,6 +19,7 @@
  */
 package net.pistonmaster.pistonqueue.shared.hooks;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import net.pistonmaster.pistonmotd.api.PlaceholderParser;
 import net.pistonmaster.pistonmotd.api.PlaceholderUtil;
 import net.pistonmaster.pistonqueue.shared.queue.QueueType;
@@ -30,6 +31,10 @@
 public final class PistonMOTDPlaceholder implements PlaceholderParser {
   private final Config config;
 
+  @SuppressFBWarnings(
+    value = "EI_EXPOSE_REP2",
+    justification = "Placeholder must reflect live configuration changes and only reads from the provided reference"
+  )
   public PistonMOTDPlaceholder(Config config) {
     this.config = config;
     PlaceholderUtil.registerParser(this);

velocity/src/main/java/net/pistonmaster/pistonqueue/velocity/PistonQueueVelocity.java

@@ -30,6 +30,7 @@
 import com.velocitypowered.api.proxy.server.RegisteredServer;
 import lombok.Getter;
 import net.kyori.adventure.text.Component;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import net.pistonmaster.pistonqueue.shared.chat.MessageType;
 import net.pistonmaster.pistonqueue.shared.config.Config;
 import net.pistonmaster.pistonqueue.shared.hooks.PistonMOTDPlaceholder;
@@ -174,6 +175,10 @@ public String getVersion() {
   }
 
   @Override
+  @SuppressFBWarnings(
+    value = "EI_EXPOSE_REP",
+    justification = "Configuration is intentionally shared and mutated via copyFrom to keep references in sync"
+  )
   public Config getConfiguration() {
     return configuration;
   }