Make DataSource#name mandatory - #89
Merged
2 commits merged intoNov 29, 2016
Merged
Conversation
ghost
force-pushed
the
mandatory-name
branch
from
November 23, 2016 10:11
97e73ea to
4045969
Compare
Author
|
@juanpedromoreno @peterneyens @raulraja take a look, we may want to bump the version number since I guess this is binary incompatible with previous 0.4.x releases. |
juanpedromoreno
approved these changes
Nov 23, 2016
juanpedromoreno
left a comment
juanpedromoreno
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thanks @dialelo
Current coverage is 76.34% (diff: 100%)@@ master #89 diff @@
==========================================
Files 10 10
Lines 242 241 -1
Methods 240 239 -1
Messages 0 0
Branches 2 2
==========================================
Hits 184 184
+ Misses 58 57 -1
Partials 0 0
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77