Support a maximum batch size per DataSource - #76
Merged
1 commit merged intoNov 9, 2016
Merged
Conversation
I changed `Concurrent` to have a `NonEmptyList` instead of a `List`, which led to some issues with the invariance of `NonEmptyList` and the existential type `FetchQuery[_, _]`, for the moment I changed it to `NonEmptyList[FetchQuery[Any, Any]]`.
Current coverage is 75.87% (diff: 92.04%)@@ master #76 diff @@
==========================================
Files 8 8
Lines 195 228 +33
Methods 190 226 +36
Messages 0 0
Branches 5 2 -3
==========================================
+ Hits 136 173 +37
+ Misses 59 55 -4
Partials 0 0
|
|
Outstanding work, well done! |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxBatchSizePhaseinterpreter which splits fetches to data sources with a maximum batch size in to multiple sequential fetches. This required a change toConcurrentto return aInMemoryCacheinstead of aDataSourceCachemaking it possible to combine multiple caches for sequential batches.processConcurrentmethod which is used in thecoreInterpreter(previously calledinterpreter) by usingXorTinstead of nestedif/elseandOption.foldand by extracting some helper methods.Fetchconstructors a better name (eg.FetchMany.astoFetchMany.ids)Fetch.multiplemethod which makes it possible to create aFetch[List[...]]directly (usingFetchManyunderneath). This can currently (and previously) be done by usingsequenceortraverse, butmultipledoesn't have the overhead of inspecting the Fetch structure to find independent fetches which can be parallelized.