Refactor and use some more cats features - #73
Merged
1 commit merged intoNov 4, 2016
Merged
Conversation
- Refactor interpreter: split out handling of `FetchOne`, `FetchMany` and `Concurrent`, use `XorT` in `processMany` to reduce nested folds, use `Validated` in `processMany` and `processConcurrent` to get missing ids/identities or some result. - (Prematurely ?) optimize `Fetch.join` - Replaced custom implementations of `map2`, `sequence` and `traverse` by using `Applicative[Fetch]` - ... I moved some methods around in the `Fetch` object and with the extraction of the three methods in the interpreter, so the diff looks much bigger than it actually is.
|
Amazing work 👏 👏, learning a lot form these contributions. |
Current coverage is 69.74% (diff: 79.51%)@@ reporting #73 diff @@
===========================================
Files 8 8
Lines 164 195 +31
Methods 158 190 +32
Messages 0 0
Branches 6 5 -1
===========================================
+ Hits 118 136 +18
- Misses 46 59 +13
Partials 0 0
|
ghost
deleted the
peter-reporting-refactor
branch
November 4, 2016 11:45
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FetchOne,FetchManyand
Concurrent, useXorTinprocessManyto reduce nested folds,use
ValidatedinprocessManyandprocessConcurrentto getmissing ids/identities or some result.
Fetch.joinmap2,sequenceandtraverseby using
Applicative[Fetch]I moved some methods around in the
Fetchobject and with theextraction of the three methods in the interpreter, so the diff looks
much bigger than it actually is.