Fix problem with fibers being cancelled due to timeout and causing fetch deadlock - #538
Merged
juanpedromoreno merged 3 commits intoSep 24, 2021
Conversation
Contributor
Author
|
Seems like the check is failing only due to the GithubExample test having bad credentials, as per the test error: |
juanpedromoreno
approved these changes
Sep 24, 2021
juanpedromoreno
left a comment
Contributor
There was a problem hiding this comment.
Thanks again @jordiolivares !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again, it seems that the process for batching across requests suffers from a deadlock issue.
In particular it can be triggered if the timeout occurs between the time the queue has been popped and the buffer is updated.
To fix this I just wrapped it in an
F.uncancelableto fix the deadlock, safely updating the reference before cancellation is finished