Stack safety of combineRequests - #227
Merged
purrgrammer merged 3 commits intoOct 25, 2019
Merged
Conversation
Contributor
🚀 The changes look good, I'll merge and cut a new release. Thanks a lot for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Our application crashed because of a
StackOverflowErrorincombineRequests.We noticed it because we run the application with
-Xss256k.Proposal
Trampoline
combineRequestsand make it stack safe.Side note
During my tests, I noticed that a big batch (5000 elements) was extremely slow to be processed.
Most of the time is spent into
combineIdentities(half inNonEmptyList.existsand the other half inNonEmptyList.:+).By changing
FetchQueryto return identities as aSet[I], the code is much faster (the big batch test went from minutes to seconds).Any objection?