Introduce Fetch#optional for performing optional fetches - #159
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 90.5% 91.12% +0.61%
==========================================
Files 5 5
Lines 158 169 +11
Branches 5 5
==========================================
+ Hits 143 154 +11
Misses 15 15
Continue to review full report at Codecov.
|
juanpedromoreno
approved these changes
Sep 19, 2018
peterneyens
reviewed
Sep 20, 2018
| case FetchDone(a) => | ||
| Done(Some(a)).asInstanceOf[FetchResult[F, Option[A]]] | ||
| case FetchMissing() => | ||
| Done(None).asInstanceOf[FetchResult[F, Option[A]]] |
Contributor
There was a problem hiding this comment.
I don't think we need the cast here. Can we try Option.empty[A]?
|
Added to the ongoing redesign of Kollect. |
bijancn
pushed a commit
to bijancn/fetch
that referenced
this pull request
Sep 19, 2019
Introduce Fetch#optional for performing optional fetches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can create
Fetchvalues withFetch#optionalinstead ofFetch#applyand you'll get back aFetch[F, Option[A]]instead of aFetch[F, A].I still want to experiment working with optional fetches using
OptionTbut this change solves #45