Allow sequential and parallel batches - #113
Merged
2 commits merged intoMar 14, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 76.66% 77.29% +0.62%
==========================================
Files 10 10
Lines 240 251 +11
Branches 2 2
==========================================
+ Hits 184 194 +10
- Misses 56 57 +1
Continue to review full report at Codecov.
|
|
👏 👏 👏 Amazing work, well done! |
Don't batch `FetchMany`s without a maximum batch size
peterneyens
force-pushed
the
peter-parallel-batches
branch
from
March 14, 2017 12:48
5b5dbe8 to
20c686e
Compare
ghost
deleted the
peter-parallel-batches
branch
March 14, 2017 14:32
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made it possible to configure if you want to execute batches to a data source sequentially or in parallel.
By default they will be parallel, so we should mention in the next release notes that people relying on the sequential execution of the batches should update their data sources to specify this sequential execution.