This repository was archived by the owner on Mar 12, 2020. It is now read-only.
Add custom feedback icons - #97
Merged
Merged
Conversation
Owner
|
I think I'd prefer to add just one option called {
success: 'glyphicon-ok',
error: 'glyphicon-warning-sign'
} |
Owner
There was a problem hiding this comment.
do callback = $.proxy(callback, this) instead of using apply and _this
Contributor
Author
|
Branch update |
Owner
There was a problem hiding this comment.
can you get rid of this semicolon?
Contributor
Author
|
Done |
1000hz
added a commit
that referenced
this pull request
Apr 4, 2015
Add custom feedback icons option
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I'm using FontAwesome Icons in my project, instead of Bootstrap Glyphicons.
My proposal is add ability to customize feedback icon classes, something like this.