Parse @pure-unless-parameter-passed via phpdoc-parser 2.3.3

phpstan/phpdoc-parser#259 is merged and released, so replace the generic-tag stopgap with PhpDocNode::getPureUnlessParameterIsPassedTagValues() and bump the dependency.

Author: zonuexe

composer.json

@@ -39,7 +39,7 @@
 		"ondrejmirtes/composer-attribute-collector": "^1.1.1",
 		"ondrejmirtes/php-merge": "^4.1",
 		"phpstan/php-8-stubs": "0.4.35",
-		"phpstan/phpdoc-parser": "2.3.2",
+		"phpstan/phpdoc-parser": "2.3.3",
 		"react/child-process": "^0.7",
 		"react/event-loop": "^1.2",
 		"react/promise": "^3.2",

composer.lock

@@ -28,7 +28,6 @@
 use PHPStan\PhpDoc\Tag\UsesTag;
 use PHPStan\PhpDoc\Tag\VarTag;
 use PHPStan\PhpDocParser\Ast\ConstExpr\ConstExprNullNode;
-use PHPStan\PhpDocParser\Ast\PhpDoc\GenericTagValueNode;
 use PHPStan\PhpDocParser\Ast\PhpDoc\MixinTagValueNode;
 use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocNode;
 use PHPStan\PhpDocParser\Ast\PhpDoc\TemplateTagValueNode;
@@ -48,10 +47,8 @@
 use function array_reverse;
 use function count;
 use function in_array;
-use function ltrim;
 use function method_exists;
 use function str_starts_with;
-use function strpos;
 use function substr;
 
 #[AutowiredService]
@@ -412,33 +409,9 @@ public function resolveParamPureUnlessCallableIsImpure(PhpDocNode $phpDocNode):
 	public function resolveParamPureUnlessParameterPassed(PhpDocNode $phpDocNode): array
 	{
 		$parameters = [];
-		// TODO: replace this generic-tag parsing with
-		// $phpDocNode->getPureUnlessParameterIsPassedTagValues() once
-		// phpstan/phpdoc-parser#259 is merged and the parser understands the tag.
 		foreach (['@pure-unless-parameter-passed', '@phpstan-pure-unless-parameter-passed'] as $tagName) {
-			foreach ($phpDocNode->getTags() as $tag) {
-				if ($tag->name !== $tagName) {
-					continue;
-				}
-				if (!$tag->value instanceof GenericTagValueNode) {
-					continue;
-				}
-
-				$value = ltrim($tag->value->value);
-				if ($value === '' || $value[0] !== '$') {
-					continue;
-				}
-
-				$parameterName = substr($value, 1);
-				$spacePosition = strpos($parameterName, ' ');
-				if ($spacePosition !== false) {
-					$parameterName = substr($parameterName, 0, $spacePosition);
-				}
-
-				if ($parameterName === '') {
-					continue;
-				}
-
+			foreach ($phpDocNode->getPureUnlessParameterIsPassedTagValues($tagName) as $tag) {
+				$parameterName = substr($tag->parameterName, 1);
 				$parameters[$parameterName] = true;
 			}
 		}