Skip to content

Commit 4095bd7

Browse files
committed
Fix indentation and code quality issues
- Fix indentation of filter block (was causing syntax issues) - Update README and feature documentation - Ensure proper code formatting
1 parent bc58b1e commit 4095bd7

3 files changed

Lines changed: 20 additions & 17 deletions

File tree

README.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,17 @@ $ gfi search -hf --limit 10 --period "48 hours"
133133
134134
</details>
135135

136+
### Filter by Language
137+
138+
$ gfi search "facebook" --language "Python"
139+
140+
### Filter by Keyword
141+
142+
$ gfi search "rust-lang" --keyword "documentation"
143+
144+
### Combine Filters
145+
146+
$ gfi search "microsoft" --language "JavaScript" --keyword "API"
136147

137148
### 📏 Search for issues within a certain period
138149

feature_language_keyword.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,3 @@ This change introduces two new CLI flags:
77
Example usage:
88
```bash
99
good-first-issues --language Python --keyword documentation
10-

good_first_issues/commands/search.py

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -176,25 +176,18 @@ def search(
176176
issues, rate_limit = services.extract_search_results(response)
177177
issues = issues[:limit] # cannot set limit on the search_query directly
178178

179-
# Apply keyword filter
180-
if keyword:
179+
# Apply filters
180+
if keyword or language: # ← ADD 4 SPACES HERE!
181181
filtered_issues = []
182182
for issue in issues:
183-
# issue is a tuple: (title, url)
184183
title = issue[0].lower()
185-
# Check if keyword is in the title
186-
if keyword.lower() in title:
187-
filtered_issues.append(issue)
188-
issues = filtered_issues
189-
190-
# Apply language filter
191-
if language:
192-
filtered_issues = []
193-
for issue in issues:
194-
# issue is a tuple: (title, url)
195-
title = issue[0].lower()
196-
# Simple language detection by keyword matching in title
197-
if language.lower() in title:
184+
# Check both filters
185+
matches = True
186+
if keyword and keyword.lower() not in title:
187+
matches = False
188+
if language and language.lower() not in title:
189+
matches = False
190+
if matches:
198191
filtered_issues.append(issue)
199192
issues = filtered_issues
200193

0 commit comments

Comments
 (0)