Skip to content

Commit e2636e3

Browse files
committed
Revert "Merge pull request #154 from remcoder/feature/api-doc"
This reverts commit 3d6a595, reversing changes made to a10cac6.
1 parent 842c9fb commit e2636e3

10 files changed

Lines changed: 71 additions & 225 deletions

.github/workflows/firebase-hosting-merge.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
steps:
1818
- uses: actions/checkout@v4
19-
- run: npm ci && npm run predemo && npm run typedoc
19+
- run: npm ci && npm run predemo
2020
- uses: FirebaseExtended/action-hosting-deploy@v0
2121
with:
2222
repoToken: '${{ secrets.GITHUB_TOKEN }}'

.github/workflows/firebase-hosting-pull-request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
steps:
2121
- uses: actions/checkout@v4
22-
- run: npm ci && npm run predemo && npm run typedoc
22+
- run: npm ci && npm run predemo
2323
- uses: FirebaseExtended/action-hosting-deploy@v0
2424
with:
2525
repoToken: '${{ secrets.GITHUB_TOKEN }}'

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,3 @@ TODO.md
1111
examples/files
1212
react-typescript-demo/.env
1313
dist/*
14-
docs

demo/index.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,7 @@ <h1>GCode Preview</h1>
203203
<div><a href="http://twitter.com/remcoder">@remcoder</a> ©2020 - 2024</div>
204204

205205
<div>
206-
<a href="https://github.com/remcoder/gcode-preview">code</a>
207-
- <a href="/docs">API docs</a>
208-
- MIT license
206+
<a href="https://github.com/remcoder/gcode-preview">code</a> - MIT license
209207
</div>
210208
</section>
211209
<section>

package-lock.json

Lines changed: 8 additions & 132 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
],
1616
"types": "dist/gcode-preview.d.ts",
1717
"devDependencies": {
18-
"@types/node": "^18.19.33",
1918
"@types/three": "^0.144.0",
2019
"@typescript-eslint/eslint-plugin": "^7.0.1",
2120
"@typescript-eslint/parser": "^7.0.1",
@@ -30,12 +29,9 @@
3029
"rollup-plugin-node-resolve": "^5.2.0",
3130
"rollup-plugin-terser": "^7.0.2",
3231
"rollup-plugin-typescript2": "^0.34.0",
33-
"typedoc": "^0.25.13",
34-
"typedoc-plugin-mdn-links": "^3.1.27",
35-
"typedoc-plugin-missing-exports": "^2.2.0",
36-
"typescript": "^4.9.5",
37-
"vitest": "^1.5.1",
38-
"watch": "^1.0.2"
32+
"typescript": "4.4",
33+
"watch": "^1.0.2",
34+
"vitest": "^1.5.1"
3935
},
4036
"scripts": {
4137
"prebuild": "del-cli dist/**/*",
@@ -54,9 +50,7 @@
5450
"version:minor": "npm version minor",
5551
"xpostversion": "npm publish && npm run deploy",
5652
"predeploy": "npm run build",
57-
"deploy": "firebase deploy --only hosting",
58-
"typedoc": "typedoc",
59-
"typedoc:watch": "typedoc --watch"
53+
"deploy": "firebase deploy --only hosting"
6054
},
6155
"dependencies": {
6256
"three": "^0.155.0"

src/gcode-parser.ts

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -102,17 +102,13 @@ export class Layer {
102102
}
103103

104104
export class Parser {
105-
private lines: string[] = [];
106-
107-
/**
108-
* @experimental GCode commands before extrusion starts.
109-
*/
110-
public preamble = new Layer(-1, [], 0); // TODO: remove preamble and treat as a regular layer? Unsure of the benefit
111-
public layers: Layer[] = [];
112-
private curZ = 0;
113-
private maxZ = -Infinity; // cannot start at 0 because of tolerance. first layer will always be created
114-
private metadata: Metadata = { thumbnails: {} };
115-
private tolerance = 0; // The higher the tolerance, the fewer layers are created, so performance will improve.
105+
lines: string[] = [];
106+
preamble = new Layer(-1, [], 0); // TODO: remove preamble and treat as a regular layer? Unsure of the benefit
107+
layers: Layer[] = [];
108+
curZ = 0;
109+
maxZ = -Infinity; // cannot start at 0 because of tolerance. first layer will always be created
110+
metadata: Metadata = { thumbnails: {} };
111+
tolerance = 0; // The higher the tolerance, the fewer layers are created, so performance will improve.
116112

117113
/**
118114
* Create a new Parser instance.
@@ -288,4 +284,3 @@ export interface Parser {
288284
parseGcode: typeof Parser.prototype.parseGCode;
289285
}
290286
Parser.prototype.parseGcode = Parser.prototype.parseGCode;
291-
export { Thumbnail };

src/gcode-preview.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import { GCodePreviewOptions, WebGLPreview, BuildVolume } from './webgl-preview';
2-
import { Parser } from './gcode-parser';
3-
import { Thumbnail } from './thumbnail';
1+
import { GCodePreviewOptions, WebGLPreview } from './webgl-preview';
2+
43
const init = function (opts: GCodePreviewOptions) {
54
return new WebGLPreview(opts);
65
};
7-
export { WebGLPreview, init, GCodePreviewOptions, BuildVolume, Parser, Thumbnail };
6+
export { WebGLPreview, init };

0 commit comments

Comments
 (0)