Skip to content

Commit fb69662

Browse files
committed
consolidate duplicate shakeType classification, clears logically dead code
1 parent d34ee11 commit fb69662

1 file changed

Lines changed: 11 additions & 19 deletions

File tree

wolfcrypt/src/rsa.c

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1154,39 +1154,31 @@ static int RsaMGF_SHAKE(enum wc_HashType shakeType, byte* seed, word32 seedSz,
11541154
return MEMORY_E);
11551155

11561156
#ifdef WOLFSSL_SHAKE128
1157-
if (shakeType == WC_HASH_TYPE_SHAKE128)
1157+
if (shakeType == WC_HASH_TYPE_SHAKE128) {
11581158
ret = wc_InitShake128(shake, heap, INVALID_DEVID);
1159-
else
1160-
#endif
1161-
#ifdef WOLFSSL_SHAKE256
1162-
if (shakeType == WC_HASH_TYPE_SHAKE256)
1163-
ret = wc_InitShake256(shake, heap, INVALID_DEVID);
1164-
else
1165-
#endif
1166-
ret = BAD_FUNC_ARG;
1167-
1168-
if (ret == 0) {
1169-
#ifdef WOLFSSL_SHAKE128
1170-
if (shakeType == WC_HASH_TYPE_SHAKE128) {
1159+
if (ret == 0) {
11711160
ret = wc_Shake128_Update(shake, seed, seedSz);
11721161
if (ret == 0)
11731162
ret = wc_Shake128_Final(shake, out, outSz);
11741163
wc_Shake128_Free(shake);
11751164
}
1176-
else
1165+
}
1166+
else
11771167
#endif
11781168
#ifdef WOLFSSL_SHAKE256
1179-
if (shakeType == WC_HASH_TYPE_SHAKE256) {
1169+
if (shakeType == WC_HASH_TYPE_SHAKE256) {
1170+
ret = wc_InitShake256(shake, heap, INVALID_DEVID);
1171+
if (ret == 0) {
11801172
ret = wc_Shake256_Update(shake, seed, seedSz);
11811173
if (ret == 0)
11821174
ret = wc_Shake256_Final(shake, out, outSz);
11831175
wc_Shake256_Free(shake);
11841176
}
1185-
else
1177+
}
1178+
else
11861179
#endif
1187-
{
1188-
ret = BAD_FUNC_ARG;
1189-
}
1180+
{
1181+
ret = BAD_FUNC_ARG;
11901182
}
11911183
WC_FREE_VAR_EX(shake, heap, DYNAMIC_TYPE_TMP_BUFFER);
11921184
return ret;

0 commit comments

Comments
 (0)