Skip to content

Commit c067687

Browse files
committed
Fix memory leak in Dilithium signing when WC_DILITHIUM_CACHE_MATRIX_A is enabled
Changed line 8321 from allocating to local variable 'a' to 'key->a' to prevent memory leak when the matrix A is dynamically allocated.
1 parent 7b53303 commit c067687

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

wolfcrypt/src/dilithium.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8318,8 +8318,8 @@ static int dilithium_sign_with_seed_mu(dilithium_key* key,
83188318
#ifdef WC_DILITHIUM_CACHE_MATRIX_A
83198319
#ifndef WC_DILITHIUM_FIXED_ARRAY
83208320
if ((ret == 0) && (key->a == NULL)) {
8321-
a = (sword32*)XMALLOC(params->aSz, key->heap, DYNAMIC_TYPE_DILITHIUM);
8322-
if (a == NULL) {
8321+
key->a = (sword32*)XMALLOC(params->aSz, key->heap, DYNAMIC_TYPE_DILITHIUM);
8322+
if (key->a == NULL) {
83238323
ret = MEMORY_E;
83248324
}
83258325
}

0 commit comments

Comments
 (0)