Skip to content

Commit a0721b9

Browse files
embhornclaude
andcommitted
Fix tls-anvil workflow: C_EXTRA_FLAGS quoting and report.json parsing
CPPFLAGS replaces C_EXTRA_FLAGS with embedded single-quotes, which were passed as literal characters through the shell variable and caused configure's C compiler test to fail. Fix the report.json summary parser to use the actual TLS-Anvil field names (TotalTests, FullyFailedTests, etc.) and include category scores. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 0898046 commit a0721b9

2 files changed

Lines changed: 12 additions & 6 deletions

File tree

.github/scripts/tls-anvil-test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ CONFIGURE_OPTS="$CONFIGURE_OPTS --enable-alpn"
110110
CONFIGURE_OPTS="$CONFIGURE_OPTS --enable-truncatedhmac"
111111
CONFIGURE_OPTS="$CONFIGURE_OPTS --enable-extended-master"
112112
CONFIGURE_OPTS="$CONFIGURE_OPTS --enable-enc-then-mac"
113-
CONFIGURE_OPTS="$CONFIGURE_OPTS C_EXTRA_FLAGS='-DWOLFSSL_EXTRA_ALERTS'"
113+
CONFIGURE_OPTS="$CONFIGURE_OPTS CPPFLAGS=-DWOLFSSL_EXTRA_ALERTS"
114114

115115
if [[ -n "$EXTRA_FLAGS" ]]; then
116116
CONFIGURE_OPTS="$CONFIGURE_OPTS $EXTRA_FLAGS"

.github/workflows/tls-anvil.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ jobs:
4545
- name: Install dependencies
4646
run: |
4747
sudo apt-get update -q
48-
sudo apt-get install -y autoconf automake libtool gcc make jq psmisc
48+
sudo apt-get install -y build-essential autoconf automake libtool jq psmisc || \
49+
sudo apt-get install -y build-essential autoconf automake libtool jq
4950
5051
- name: Pull TLS-Anvil Docker image
5152
run: docker pull ghcr.io/tls-attacker/tlsanvil:latest
@@ -70,11 +71,16 @@ jobs:
7071
echo "| | Count |"
7172
echo "|---|---|"
7273
jq -r '
73-
"| Total | \(.Score.Total // "N/A") |",
74-
"| Passed | \(.Score.Succeeded // "N/A") |",
75-
"| Failed | \(.Score.Failed // "N/A") |",
76-
"| Disabled | \(.Score.Disabled // "N/A") |"
74+
"| Total | \(.TotalTests // "N/A") |",
75+
"| Strictly Passed | \(.StrictlySucceededTests // "N/A") |",
76+
"| Conceptually OK | \(.ConceptuallySucceededTests // "N/A") |",
77+
"| Partially Failed | \(.PartiallyFailedTests // "N/A") |",
78+
"| Fully Failed | \(.FullyFailedTests // "N/A") |",
79+
"| Disabled | \(.DisabledTests // "N/A") |"
7780
' "$REPORT" 2>/dev/null || echo "| (could not parse report.json) | — |"
81+
echo ""
82+
echo "**Category scores:**"
83+
jq -r '.Score | to_entries[] | "- \(.key): \(.value)%"' "$REPORT" 2>/dev/null || true
7884
else
7985
echo "No report.json found — check step logs for errors."
8086
fi

0 commit comments

Comments
 (0)