Fix missing return code check in wc_PKCS12_parse_ex.

kareem-wolfssl · kareem-wolfssl · commit 2fc2a53d9477 · 2026-04-20T10:44:47.000-07:00
Thanks to Zou Dikai for the report.
diff --git a/wolfcrypt/src/pkcs12.c b/wolfcrypt/src/pkcs12.c
@@ -1546,8 +1546,13 @@ int wc_PKCS12_parse_ex(WC_PKCS12* pkcs12, const char* psw,
                             *pkeySz = (word32)size;
                         }
                         else {
-                            *pkeySz = (word32)ToTraditional_ex(*pkey,
+                            ret = ToTraditional_ex(*pkey,
                                 (word32)size, &algId);
+                            if (ret < 0) {
+                                goto exit_pk12par;
+                            } else {
+                                *pkeySz = (word32)ret;
+                            }
                         }
                     }
 

Original file line number	Diff line number	Diff line change
`@@ -1546,8 +1546,13 @@ int wc_PKCS12_parse_ex(WC_PKCS12* pkcs12, const char* psw,`
`1546`	`1546`	`*pkeySz = (word32)size;`
`1547`	`1547`	`}`
`1548`	`1548`	`else {`
`1549`		`- pkeySz = (word32)ToTraditional_ex(pkey,`
	`1549`	`+ ret = ToTraditional_ex(*pkey,`
`1550`	`1550`	`(word32)size, &algId);`
	`1551`	`+ if (ret < 0) {`
	`1552`	`+ goto exit_pk12par;`
	`1553`	`+ } else {`
	`1554`	`+ *pkeySz = (word32)ret;`
	`1555`	`+ }`
`1551`	`1556`	`}`
`1552`	`1557`	`}`
`1553`	`1558`