CI: trigger on all branches and fix unit test assertions

  - Update all workflow push triggers from specific branches to ['*']
    so CI runs on feature/fix branches
  - Fix 3 unit tests that assert TCP_ESTABLISHED after accept(); the
    SYN-ACK retransmission fix correctly keeps accepted sockets in
    TCP_SYN_RCVD until the final ACK completes the handshake

Author: aidangarske

.github/workflows/cppcheck.yml

@@ -2,7 +2,7 @@ name: CppCheck code linter
 
 on:
   push:
-    branches: [ 'master', 'main', 'release/**' ]
+    branches: [ '*' ]
   pull_request:
     branches: [ '*' ]
 

.github/workflows/freebsd.yml

@@ -2,7 +2,7 @@ name: FreeBSD interop tests
 
 on:
   push:
-    branches: [ 'master', 'main', 'release/**' ]
+    branches: [ '*' ]
   pull_request:
     branches: [ '*' ]
 

.github/workflows/linux.yml

@@ -2,7 +2,7 @@ name: Linux interop tests
 
 on:
   push:
-    branches: [ 'master', 'main', 'release/**' ]
+    branches: [ '*' ]
   pull_request:
     branches: [ '*' ]
 

.github/workflows/macos.yml

@@ -2,7 +2,7 @@ name: macOS interop tests
 
 on:
   push:
-    branches: [ 'master', 'main', 'release/**' ]
+    branches: [ '*' ]
   pull_request:
     branches: [ '*' ]
 

src/test/unit/unit.c

@@ -5608,7 +5608,9 @@ START_TEST(test_sock_accept_success)
     new_sd = wolfIP_sock_accept(&s, listen_sd, (struct wolfIP_sockaddr *)&sin, &alen);
     ck_assert_int_gt(new_sd, 0);
     new_ts = &s.tcpsockets[SOCKET_UNMARK(new_sd)];
-    ck_assert_int_eq(new_ts->sock.tcp.state, TCP_ESTABLISHED);
+    /* After accept(), socket stays in SYN_RCVD until final ACK completes
+     * the three-way handshake (SYN-ACK retransmission fix). */
+    ck_assert_int_eq(new_ts->sock.tcp.state, TCP_SYN_RCVD);
     ck_assert_uint_eq(sin.sin_port, ee16(new_ts->dst_port));
 
     listen_ts = &s.tcpsockets[SOCKET_UNMARK(listen_sd)];
@@ -14706,7 +14708,8 @@ START_TEST(test_tcp_listen_accepts_bound_interface)
     client = &s.tcpsockets[SOCKET_UNMARK(client_fd)];
     ck_assert_uint_eq(client->local_ip, secondary_ip);
     ck_assert_uint_eq(client->bound_local_ip, secondary_ip);
-    ck_assert_int_eq(client->sock.tcp.state, TCP_ESTABLISHED);
+    /* After accept(), socket stays in SYN_RCVD until final ACK. */
+    ck_assert_int_eq(client->sock.tcp.state, TCP_SYN_RCVD);
 }
 END_TEST
 
@@ -14745,7 +14748,8 @@ START_TEST(test_tcp_listen_accepts_any_interface)
     ck_assert_int_ge(client_fd, 0);
     client = &s.tcpsockets[SOCKET_UNMARK(client_fd)];
     ck_assert_uint_eq(client->local_ip, secondary_ip);
-    ck_assert_int_eq(client->sock.tcp.state, TCP_ESTABLISHED);
+    /* After accept(), socket stays in SYN_RCVD until final ACK. */
+    ck_assert_int_eq(client->sock.tcp.state, TCP_SYN_RCVD);
 }
 END_TEST