Fix new coverity issue in BrokerRetained_Store

embhorn · embhorn · commit fd3c39e1fc04 · 2026-03-20T07:59:21.000-05:00
diff --git a/src/mqtt_broker.c b/src/mqtt_broker.c
@@ -1877,6 +1877,8 @@ static int BrokerRetained_Store(MqttBroker* broker, const char* topic,
                 XMEMSET(msg, 0, sizeof(*msg));
                 msg->topic = (char*)WOLFMQTT_MALLOC((size_t)tlen + 1);
                 if (msg->topic == NULL) {
+                    WOLFMQTT_FREE(msg);
+                    msg = NULL;
                     rc = MQTT_CODE_ERROR_MEMORY;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -1877,6 +1877,8 @@ static int BrokerRetained_Store(MqttBroker* broker, const char* topic,`
`1877`	`1877`	`XMEMSET(msg, 0, sizeof(*msg));`
`1878`	`1878`	`msg->topic = (char*)WOLFMQTT_MALLOC((size_t)tlen + 1);`
`1879`	`1879`	`if (msg->topic == NULL) {`
	`1880`	`+ WOLFMQTT_FREE(msg);`
	`1881`	`+ msg = NULL;`
`1880`	`1882`	`rc = MQTT_CODE_ERROR_MEMORY;`
`1881`	`1883`	`}`
`1882`	`1884`	`}`