Fix null deref in MqttClient_Ping

embhorn · embhorn · commit cfdf800768a9 · 2026-04-21T09:37:37.000-05:00
diff --git a/src/mqtt_client.c b/src/mqtt_client.c
@@ -2581,6 +2581,9 @@ int MqttClient_Ping_ex(MqttClient *client, MqttPing* ping)
 
 int MqttClient_Ping(MqttClient *client)
 {
+    if (client == NULL) {
+        return MQTT_TRACE_ERROR(MQTT_CODE_ERROR_BAD_ARG);
+    }
     return MqttClient_Ping_ex(client, &client->msg.ping);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2581,6 +2581,9 @@ int MqttClient_Ping_ex(MqttClient client, MqttPing ping)`
`2581`	`2581`
`2582`	`2582`	`int MqttClient_Ping(MqttClient *client)`
`2583`	`2583`	`{`
	`2584`	`+ if (client == NULL) {`
	`2585`	`+ return MQTT_TRACE_ERROR(MQTT_CODE_ERROR_BAD_ARG);`
	`2586`	`+ }`
`2584`	`2587`	`return MqttClient_Ping_ex(client, &client->msg.ping);`
`2585`	`2588`	`}`
`2586`	`2589`