Implement copilot suggestions

Author: julek-wolfssl

src/ocsp/clu_ocsp.c

@@ -788,8 +788,10 @@ static int ocspResponder(OcspResponderConfig* config)
         goto cleanup;
     }
 
+#ifndef _WIN32
     /* Setup signal handlers for graceful shutdown */
     setupSignalHandlers();
+#endif
 
     WOLFCLU_LOG(WOLFCLU_L0, "OCSP responder%s listening on port %d", 
                 (transportType == TRANSPORT_SCGI) ? " (SCGI mode)" : "", config->port);
@@ -865,10 +867,6 @@ static int ocspResponder(OcspResponderConfig* config)
 
         wolfCLU_ServerClose(clientfd);
         clientfd = INVALID_SOCKET;
-        
-        if (config->nrequest > 0 && requestsProcessed >= config->nrequest) {
-            break;
-        }
     }
 
     ret = WOLFCLU_SUCCESS;

src/tools/clu_http.c

@@ -281,8 +281,11 @@ int wolfCLU_HttpServerRecv(SOCKET_T clientfd, byte* buffer, int bufferSz)
                 cl = XSTRSTR((char*)buffer, "Content-Length:");
                 if (cl == NULL)
                     cl = XSTRSTR((char*)buffer, "content-length:");
-                if (cl != NULL)
+                if (cl != NULL) {
                     contentLen = XATOI(cl + 15);
+                    if (contentLen < 0)
+                        contentLen = 0;
+                }
             }
         }
         /* Check if we have the full body */
@@ -403,6 +406,9 @@ int wolfCLU_HttpServerParseRequest(const byte* httpReq, int httpReqSz,
     }
     if (contentLen) {
         *bodySz = XATOI(contentLen + 15);
+        if (*bodySz < 0) {
+            return -1;
+        }
     }
 
     /* Find body (after \r\n\r\n) */

src/tools/clu_pem_der.c

@@ -80,8 +80,8 @@ static int loadFileToDer(const char* filename, byte** der, word32* derSz, int pe
                 XMEMCPY(*der, pDer->buffer, pDer->length);
                 *derSz = pDer->length;
             }
-            wc_FreeDer(&pDer);
         }
+        wc_FreeDer(&pDer);
         XFREE(buf, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
         return (*der != NULL) ? 0 : -1;
     }

src/tools/clu_scgi.c

@@ -96,6 +96,9 @@ static int parseNetstringLength(SOCKET_T sockfd, int* length)
         if (lenBuf[i] == ':') {
             lenBuf[i] = '\0';
             *length = XATOI(lenBuf);
+            if (*length < 0) {
+                return -1;
+            }
             return 0;
         }
         i++;

tests/ocsp-scgi/scgi_params

@@ -5,7 +5,6 @@ scgi_param  CONTENT_TYPE       $content_type;
 scgi_param  CONTENT_LENGTH     $content_length;
 
 scgi_param  SCRIPT_NAME        $fastcgi_script_name;
-scgi_param  REQUEST_URI        $request_uri;
 scgi_param  DOCUMENT_URI       $document_uri;
 scgi_param  DOCUMENT_ROOT      $document_root;
 scgi_param  SERVER_PROTOCOL    $server_protocol;