fix(Support): extract impure helpers and remove all eslint-disable comments

Author: sujalgoel

src/components/Support/Support.data.test.jsx

@@ -1,11 +1,11 @@
 /**
  * @jest-environment jsdom
  */
-// eslint-disable-next-line import/no-extraneous-dependencies
-import { beforeEach, describe, expect, it, jest } from "@jest/globals";
 import { act, fireEvent, render, screen } from "@testing-library/react";
 import SmallIcon from "../../assets/icon-square-small-slack.png";
 
+import Support from "./Support.jsx";
+
 // Data must be inline - jest.mock is hoisted before const declarations (TDZ)
 jest.mock("./AdditionalSupporters.mjs", () => []);
 jest.mock(
@@ -25,9 +25,6 @@ jest.mock(
   { virtual: true },
 );
 
-// eslint-disable-next-line import/first
-import Support from "./Support.jsx";
-
 const AVATAR_URL = "https://example.com/avatar.png";
 
 describe("Support with supporter data", () => {

src/components/Support/Support.jsx

@@ -101,6 +101,25 @@ function handleImgError(event) {
   imgNode.setAttribute("src", SmallIcon);
 }
 
+function filterByAge(result, age) {
+  const now = Date.now();
+  return result.filter(
+    (item) =>
+      item.firstDonation && now - new Date(item.firstDonation).getTime() < age,
+  );
+}
+
+function shuffleSlice(arr, n) {
+  const result = [...arr];
+  for (let i = 0; i < n; i++) {
+    const other = Math.floor(Math.random() * (result.length - i));
+    const temp = result[other];
+    result[other] = result[i];
+    result[i] = temp;
+  }
+  return result.slice(0, n);
+}
+
 export default function Support({ rank, type }) {
   const [inView, setInView] = useState(false);
   const containerRef = useRef(null);
@@ -156,30 +175,15 @@ export default function Support({ rank, type }) {
       }
 
       if (typeof age === "number") {
-        // eslint-disable-next-line react-hooks/purity
-        const now = Date.now();
-        result = result.filter(
-          (item) =>
-            item.firstDonation &&
-            now - new Date(item.firstDonation).getTime() < age,
-        );
+        result = filterByAge(result, age);
       }
 
       if (typeof lim === "number") {
         result = result.slice(0, lim);
       }
 
       if (typeof rand === "number" && result.length >= rand) {
-        // Pick n random items
-        result = [...result];
-        for (let i = 0; i < rand; i++) {
-          // eslint-disable-next-line react-hooks/purity
-          const other = Math.floor(Math.random() * (result.length - i));
-          const temp = result[other];
-          result[other] = result[i];
-          result[i] = temp;
-        }
-        result = result.slice(0, rand);
+        result = shuffleSlice(result, rand);
       }
 
       // resort to keep order

src/components/Support/Support.test.jsx

@@ -1,16 +1,13 @@
 /**
  * @jest-environment jsdom
  */
-// eslint-disable-next-line import/no-extraneous-dependencies
-import { beforeEach, describe, expect, it, jest } from "@jest/globals";
 import { render, screen } from "@testing-library/react";
 
+import Support from "./Support.jsx";
+
 jest.mock("./AdditionalSupporters.mjs", () => []);
 jest.mock("./_supporters.json", () => [], { virtual: true });
 
-// eslint-disable-next-line import/first
-import Support from "./Support.jsx";
-
 describe("Support", () => {
   let mockObserve;
   let mockDisconnect;