Fix coverage

Author: vsdudakov

.github/workflows/ci.yml

@@ -37,4 +37,10 @@ jobs:
       - name: Run Build
         run: make -C frontend build
       - name: Upload coverage reports to Codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          files: ./coverage.xml,./frontend/coverage/lcov.info
+          flags: backend,frontend
+          fail_ci_if_error: true
+          verbose: true

README.md

@@ -1,6 +1,6 @@
 # Admin Dashboard for FastAPI / Flask / Django
 
-[![codecov](https://codecov.io/gh/vsdudakov/fastadmin/branch/main/graph/badge.svg?token=RNGX5HOW3T)](https://codecov.io/gh/vsdudakov/fastadmin)
+[![codecov](https://codecov.io/gh/vsdudakov/fastadmin/branch/main/graph/badge.svg?token=RNGX5HOW3T)](https://app.codecov.io/gh/vsdudakov/fastadmin)
 [![License](https://img.shields.io/github/license/vsdudakov/fastadmin)](https://github.com/vsdudakov/fastadmin/blob/master/LICENSE)
 [![PyPi](https://badgen.net/pypi/v/fastadmin)](https://pypi.org/project/fastadmin/)
 [![Python 3.12](https://img.shields.io/badge/python-3.12-blue.svg)](https://www.python.org/downloads/release/python-3120/)

docs/index.html

@@ -196,6 +196,10 @@ <h4 class="title">FastAdmin</h4>
 
               <ul class="nav flex-column">
 
+                <li class="nav-item">
+                  <a class="nav-link" href="#v0_3_3">v0.3.3</a>
+                </li>
+                
                 <li class="nav-item">
                   <a class="nav-link" href="#v0_3_2">v0.3.2</a>
                 </li>
@@ -315,7 +319,7 @@ <h1>FastAdmin | Documentation</h1>
               <div class="row">
                 <div class="col-sm-6 col-lg-4">
                   <ul class="list-unstyled">
-                    <li><strong>Version:</strong> 0.3.2</li>
+                    <li><strong>Version:</strong> 0.3.3</li>
                     <li>
                       <strong>Author:</strong>
                       <a href="mailto:vsdudakov@gmail.com" target="_blank">
@@ -3250,6 +3254,67 @@ <h2>Changelog</h2>
 
 
 
+                <section id="v0_3_3">
+                <h3>v0.3.3</h3>
+
+                
+                  
+<p class="text-4">
+  Fix DetachedInstanceError when session is closed after commit.
+</p>
+
+
+
+
+
+
+
+
+
+
+
+
+
+                
+                  
+<p class="text-4">
+  Fix list display widths.
+</p>
+
+
+
+
+
+
+
+
+
+
+
+
+
+                
+                  
+<p class="text-4">
+  Fix flask issues.
+</p>
+
+
+
+
+
+
+
+
+
+
+
+
+
+                
+                </section>
+
+              
                 <section id="v0_3_2">
                 <h3>v0.3.2</h3>
 

docs/templates/readme.md

@@ -1,6 +1,6 @@
 # Admin Dashboard for FastAPI / Flask / Django
 
-[![codecov](https://codecov.io/gh/vsdudakov/fastadmin/branch/main/graph/badge.svg?token=RNGX5HOW3T)](https://codecov.io/gh/vsdudakov/fastadmin)
+[![codecov](https://codecov.io/gh/vsdudakov/fastadmin/branch/main/graph/badge.svg?token=RNGX5HOW3T)](https://app.codecov.io/gh/vsdudakov/fastadmin)
 [![License](https://img.shields.io/github/license/vsdudakov/fastadmin)](https://github.com/vsdudakov/fastadmin/blob/master/LICENSE)
 [![PyPi](https://badgen.net/pypi/v/fastadmin)](https://pypi.org/project/fastadmin/)
 [![Python 3.12](https://img.shields.io/badge/python-3.12-blue.svg)](https://www.python.org/downloads/release/python-3120/)

frontend/src/components/async-transfer/index.test.tsx

@@ -75,14 +75,18 @@ describe("AsyncTransfer", () => {
     act(() => {
       transferPropsRef.current.onSearch("right", "should-not-apply");
     });
-    let lastQuery = mockUseQuery.mock.calls.at(-1)?.[0] as any;
+    let lastQuery = mockUseQuery.mock.calls[
+      mockUseQuery.mock.calls.length - 1
+    ]?.[0] as any;
     expect(lastQuery.queryKey[1]).not.toContain("should-not-apply");
 
     act(() => {
       transferPropsRef.current.onSearch("left", "john");
     });
     await waitFor(() => {
-      lastQuery = mockUseQuery.mock.calls.at(-1)?.[0] as any;
+      lastQuery = mockUseQuery.mock.calls[
+        mockUseQuery.mock.calls.length - 1
+      ]?.[0] as any;
       expect(lastQuery.queryKey[1]).toContain("search=john");
     });
   });

frontend/src/components/sign-in-container/index.test.tsx

@@ -13,7 +13,7 @@ test("Renders SignInContainer", () => {
       <SignInUserContext.Provider
         value={{
           signedIn: false,
-          signedInUser: null,
+          signedInUser: undefined,
           signedInUserRefetch: () => Promise.resolve(undefined as any),
         }}
       >

frontend/src/components/table-or-cards/cards/index.test.tsx

@@ -31,8 +31,8 @@ describe("Cards", () => {
         ]}
         rowSelection={{ selectedRowKeys: [], onChange: onRowSelectionChange }}
         expandable={{
-          expandIcon: ({ expanded, onExpand }) => (
-            <button type="button" onClick={onExpand}>
+          expandIcon: ({ expanded, onExpand, record }) => (
+            <button type="button" onClick={(event) => onExpand(record, event)}>
               {expanded ? "Collapse" : "Expand"}
             </button>
           ),

frontend/src/helpers/title.test.ts

@@ -15,9 +15,6 @@ describe("getTitleFromModel", () => {
       verbose_name: "User",
       verbose_name_plural: "Users",
       fields: [],
-      list_display: [],
-      list_filter: [],
-      sortable_by: [],
       search_fields: [],
       actions: [],
       permissions: [],
@@ -32,9 +29,6 @@ describe("getTitleFromModel", () => {
       verbose_name: "Event",
       verbose_name_plural: "Events",
       fields: [],
-      list_display: [],
-      list_filter: [],
-      sortable_by: [],
       search_fields: [],
       actions: [],
       permissions: [],
@@ -47,9 +41,6 @@ describe("getTitleFromModel", () => {
       name: "AuditLog",
       verbose_name: "Audit log",
       fields: [],
-      list_display: [],
-      list_filter: [],
-      sortable_by: [],
       search_fields: [],
       actions: [],
       permissions: [],
@@ -61,9 +52,6 @@ describe("getTitleFromModel", () => {
     const model: IModel = {
       name: "BaseEvent",
       fields: [],
-      list_display: [],
-      list_filter: [],
-      sortable_by: [],
       search_fields: [],
       actions: [],
       permissions: [],
@@ -76,9 +64,6 @@ describe("getTitleFromModel", () => {
     const model: IModel = {
       name: "event",
       fields: [],
-      list_display: [],
-      list_filter: [],
-      sortable_by: [],
       search_fields: [],
       actions: [],
       permissions: [],

frontend/src/helpers/widgets.test.ts

@@ -32,7 +32,7 @@ describe("getWidgetCls", () => {
 
   it("returns DatePicker.RangePicker with placeholder", () => {
     const [, props] = getWidgetCls(EFieldWidgetType.RangePicker, _t);
-    expect(props.placeholder).toEqual(["Start", "End"]);
+    expect((props as any).placeholder).toEqual(["Start", "End"]);
   });
 
   it("returns default Input for unknown type", () => {

frontend/vite.config.ts

@@ -9,7 +9,7 @@ export default defineConfig({
     setupFiles: ["src/test-setup.ts"],
     coverage: {
       provider: "v8",
-      reporter: ["text", "text-summary", "html"],
+      reporter: ["text", "text-summary", "html", "lcov"],
       include: ["src/**/*.{ts,tsx}"],
       exclude: [
         "src/**/*.test.{ts,tsx}",