Skip to content

Commit d5fbfd3

Browse files
committed
fix: use email as fallback for GitHub nickname if not provided
1 parent 01fa328 commit d5fbfd3

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

core/src/main/java/com/databasir/core/domain/app/handler/GithubOpenAuthHandler.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import com.databasir.dao.tables.pojos.OauthApp;
1010
import com.databasir.dao.tables.pojos.OauthAppProperty;
1111
import com.fasterxml.jackson.databind.JsonNode;
12+
import com.google.common.base.Strings;
1213
import lombok.RequiredArgsConstructor;
1314
import org.jooq.tools.StringUtils;
1415
import org.springframework.security.authentication.CredentialsExpiredException;
@@ -77,6 +78,9 @@ public OAuthProcessResult process(OauthApp app,
7778
}
7879
JsonNode profile = githubRemoteService.getProfile(resourceUrl, accessToken);
7980
String nickname = profile.get("name").asText();
81+
if (Strings.isNullOrEmpty(nickname)) {
82+
nickname = email;
83+
}
8084
String avatar = profile.get("avatar_url").asText();
8185
OAuthProcessResult result = new OAuthProcessResult();
8286
result.setEmail(email);

databasir-frontend

0 commit comments

Comments
 (0)