Skip to content

Commit a1d9493

Browse files
authored
remove gcs dead code from vortex-bench (#7640)
## Summary AFAIK we do not use gcs as a storage backend. I'm guessing this is a historical artifact? ## Testing N/A Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
1 parent 1838a7a commit a1d9493

3 files changed

Lines changed: 3 additions & 6 deletions

File tree

vortex-bench/src/measurements.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ pub struct QueryMeasurement {
244244
pub target: Target,
245245
pub benchmark_dataset: BenchmarkDataset,
246246
pub benchmark_runner: String,
247-
/// The storage backend against which this test was run. One of: s3, gcs, nvme.
247+
/// The storage backend against which this test was run. One of: s3, nvme.
248248
pub storage: String,
249249
pub runs: Vec<Duration>,
250250
}

vortex-bench/src/utils/constants.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,3 @@
44
/// Storage type constants
55
pub const STORAGE_NVME: &str = "nvme";
66
pub const STORAGE_S3: &str = "s3";
7-
pub const STORAGE_GCS: &str = "gcs";

vortex-bench/src/utils/file.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,20 +154,18 @@ pub fn resolve_data_url(remote_data_dir: Option<&str>, local_subdir: &str) -> Re
154154

155155
/// Convert a URL scheme to a storage type string
156156
///
157-
/// Maps URL schemes (s3, gcs, file) to storage type identifiers
157+
/// Maps URL schemes (s3, file) to storage type identifiers
158158
/// for benchmark reporting.
159159
///
160160
/// # Returns
161-
/// - A storage type string ("s3", "gcs", "nvme")
161+
/// - A storage type string ("s3", "nvme")
162162
/// - Or an error if the scheme is unknown
163163
pub fn url_scheme_to_storage(url: &Url) -> Result<String> {
164-
use super::constants::STORAGE_GCS;
165164
use super::constants::STORAGE_NVME;
166165
use super::constants::STORAGE_S3;
167166

168167
match url.scheme() {
169168
STORAGE_S3 => Ok(STORAGE_S3.to_owned()),
170-
STORAGE_GCS => Ok(STORAGE_GCS.to_owned()),
171169
"file" => Ok(STORAGE_NVME.to_owned()),
172170
otherwise => {
173171
bail!("unknown URL scheme: {}", otherwise)

0 commit comments

Comments
 (0)