Allow bot approvals (#7774)

Since we use renovate-approval[bot] to approve renovate PRs.

We still require 2 approvals for any non-whitelisted bot-authored PRs.

But this will fix the queue of renovate PRs

Signed-off-by: Nicholas Gates <nick@nickgates.com>

Author: gatesn

.github/workflows/approvals.yml

@@ -23,21 +23,20 @@ jobs:
               pull_number: pr.number,
             });
 
-            // Count unique human approvals (latest review per user)
+            // Determine if PR author is a bot/GitHub Actions
+            const authorType = pr.user.type;        // 'Bot' vs 'User'
+            const authorLogin = pr.user.login;       // e.g. 'github-actions[bot]'
+            const isBot = authorType === 'Bot' || authorLogin.endsWith('[bot]');
+            const oneApprovalBotAuthors = new Set(['renovate[bot]']);
+
+            // Count unique approvals, including bot approvals.
             const latestByUser = {};
             for (const review of reviews.data) {
-              if (review.user.type === 'Bot') continue;
               latestByUser[review.user.login] = review.state;
             }
             const approvalCount = Object.values(latestByUser)
               .filter(state => state === 'APPROVED').length;
 
-            // Determine if PR author is a bot/GitHub Actions
-            const authorType = pr.user.type;        // 'Bot' vs 'User'
-            const authorLogin = pr.user.login;       // e.g. 'github-actions[bot]'
-            const isBot = authorType === 'Bot' || authorLogin.endsWith('[bot]');
-            const oneApprovalBotAuthors = new Set(['renovate[bot]']);
-
             const required = isBot && !oneApprovalBotAuthors.has(authorLogin) ? 2 : 1;
 
             console.log(`PR author: ${authorLogin} (${authorType}), isBot: ${isBot}`);
@@ -46,7 +45,7 @@ jobs:
 
             if (isBot && (approvalCount < required))  {
               core.setFailed(
-                `This PR needs ${required} human approval(s) but has ${approvalCount}. ` +
+                `This PR needs ${required} approval(s) but has ${approvalCount}. ` +
                 `(Author is ${isBot ? 'a bot' : 'human'})`
               );
             }