refactor(logger): improve getSuggestLogFilePath method

Author: zaldih

__tests__/logger.service.test.ts

@@ -1,4 +1,5 @@
 import { jest } from '@jest/globals';
+import { normalize } from 'path';
 
 const writeFileSyncMock = jest.fn();
 const renameFileSyncMock = jest.fn();
@@ -101,22 +102,22 @@ describe('LoggerService', () => {
 
   describe('getSuggestLogfilePath', () => {
     it('the path should includes the os tmp dir', () => {
-      const path = logger.getSuggestLogfilePath();
-      expect(path.includes('/tmpDir')).toBeTruthy();
+      const path = logger.getSuggestLogFilePath();
+      expect(path.includes(normalize('/tmpDir'))).toBeTruthy();
     });
   });
 
   describe('LogFile rotation', () => {
     it('should not rotate file if not exist', () => {
       existsSyncMock.mockReturnValue(false);
-      const path = logger.getSuggestLogfilePath();
+      const path = logger.getSuggestLogFilePath();
       logger.saveToFile(path);
       expect(renameFileSyncMock).not.toBeCalled();
     });
 
     it('should rotate file if exist', () => {
       existsSyncMock.mockReturnValue(true);
-      const path = logger.getSuggestLogfilePath();
+      const path = logger.getSuggestLogFilePath();
       logger.saveToFile(path);
       const expectedOldPath = path.replace('latest', 'old');
       expect(renameFileSyncMock).toBeCalledWith(path, expectedOldPath);

src/controller.ts

@@ -487,7 +487,7 @@ export class Controller {
     this.uiService.print('\n');
     this.uiService.setRawMode(false);
     this.uiService.setCursorVisible(true);
-    const logPath = this.logger.getSuggestLogfilePath();
+    const logPath = this.logger.getSuggestLogFilePath();
     this.logger.saveToFile(logPath);
     process.exit(1);
   }
@@ -498,7 +498,7 @@ export class Controller {
     this.uiService.setCursorVisible(true);
     this.printExitMessage();
     this.logger.info('Thank for using npkill. Bye!');
-    const logPath = this.logger.getSuggestLogfilePath();
+    const logPath = this.logger.getSuggestLogFilePath();
     this.logger.saveToFile(logPath);
     process.exit();
   }

src/services/logger.service.ts

@@ -52,8 +52,9 @@ export class LoggerService {
     writeFileSync(path, content);
   }
 
-  getSuggestLogfilePath(): string {
-    return `${tmpdir()}/npkill-${LATEST_TAG}.log`;
+  getSuggestLogFilePath(): string {
+    const filename = `npkill-${LATEST_TAG}.log`;
+    return join(tmpdir(), filename);
   }
 
   private rotateLogFile(newLogPath: string): void {