refactor userver: drop explicit operator!=

Anton3 · Anton3 · commit c6839fe816e1 · 2026-04-24T18:31:41.000+03:00
commit_hash:456a870478ab7b164a843296a363b21bb6ce8cfa
diff --git a/core/include/userver/dump/config.hpp b/core/include/userver/dump/config.hpp
@@ -50,7 +50,6 @@ struct DynamicConfig final {
     explicit DynamicConfig(const Config& config, ConfigPatch&& patch);
 
     bool operator==(const DynamicConfig& other) const noexcept;
-    bool operator!=(const DynamicConfig& other) const noexcept;
 
     bool dumps_enabled;
     std::chrono::milliseconds min_dump_interval;
diff --git a/core/include/userver/utils/periodic_task.hpp b/core/include/userver/utils/periodic_task.hpp
@@ -101,7 +101,6 @@ class PeriodicTask final {
         {}
 
         bool operator==(const Settings& other) const noexcept;
-        bool operator!=(const Settings& other) const noexcept;
 
         // Note: Tidy requires us to explicitly initialize these fields, although
         // the initializers are never used.
diff --git a/core/include/userver/utils/trx_tracker.hpp b/core/include/userver/utils/trx_tracker.hpp
@@ -50,7 +50,6 @@ class TaskId final {
     TaskId();
 
     bool operator==(const TaskId& other) const;
-    bool operator!=(const TaskId& other) const;
 
 private:
     std::thread::id created_thread_id_;
diff --git a/core/src/cache/expirable_lru_cache_test.cpp b/core/src/cache/expirable_lru_cache_test.cpp
@@ -49,8 +49,6 @@ class Counter {
 
     bool operator==(const Counter& other) const { return value_ == other.value_; }
 
-    bool operator!=(const Counter& other) const { return !(*this == other); }
-
     Counter& operator++() {
         value_++;
         return *this;
diff --git a/core/src/dump/config.cpp b/core/src/dump/config.cpp
@@ -74,8 +74,6 @@ bool DynamicConfig::operator==(const DynamicConfig& other) const noexcept {
     return dumps_enabled == other.dumps_enabled && min_dump_interval == other.min_dump_interval;
 }
 
-bool DynamicConfig::operator!=(const DynamicConfig& other) const noexcept { return !(*this == other); }
-
 }  // namespace dump
 
 USERVER_NAMESPACE_END
diff --git a/core/src/utils/periodic_task.cpp b/core/src/utils/periodic_task.cpp
@@ -72,10 +72,6 @@ bool PeriodicTask::Settings::operator==(const Settings& other) const noexcept {
     return TieSettings(*this) == TieSettings(other);
 }
 
-bool PeriodicTask::Settings::operator!=(const Settings& other) const noexcept {
-    return TieSettings(*this) != TieSettings(other);
-}
-
 PeriodicTask::PeriodicTask()
     : impl_()
 {}
diff --git a/core/src/utils/statistics/histogram_view.cpp b/core/src/utils/statistics/histogram_view.cpp
@@ -67,14 +67,10 @@ double HistogramView::GetTotalSum() const noexcept {
     return total;
 }
 
-void DumpMetric(Writer& writer, HistogramView histogram) { writer = histogram; }
-
 bool operator==(HistogramView lhs, HistogramView rhs) noexcept {
     return impl::histogram::HasSameBoundsAndValues(lhs, rhs);
 }
 
-bool operator!=(HistogramView lhs, HistogramView rhs) noexcept { return !(lhs == rhs); }
-
 }  // namespace utils::statistics
 
 USERVER_NAMESPACE_END
diff --git a/core/src/utils/trx_tracker.cpp b/core/src/utils/trx_tracker.cpp
@@ -102,8 +102,6 @@ bool TaskId::operator==(const TaskId& other) const {
     return created_thread_id_ == other.created_thread_id_ && thread_local_counter_ == other.thread_local_counter_;
 }
 
-bool TaskId::operator!=(const TaskId& other) const { return !(*this == other); }
-
 }  // namespace impl
 
 TransactionLock::~TransactionLock() { Unlock(); }
diff --git a/kafka/include/userver/kafka/headers.hpp b/kafka/include/userver/kafka/headers.hpp
@@ -65,7 +65,6 @@ class HeadersIterator {
     reference operator*() const;
 
     bool operator==(const HeadersIterator&) const;
-    bool operator!=(const HeadersIterator&) const;
 
 private:
     const rd_kafka_headers_s* headers_{nullptr};
diff --git a/kafka/src/kafka/headers.cpp b/kafka/src/kafka/headers.cpp
@@ -68,8 +68,6 @@ bool HeadersIterator::operator==(const HeadersIterator& other) const {
     return std::tie(headers_, index_) == std::tie(other.headers_, other.index_);
 }
 
-bool HeadersIterator::operator!=(const HeadersIterator& other) const { return !(*this == other); }
-
 HeadersReader::HeadersReader(const rd_kafka_headers_t* headers)
     : headers_{headers},
       size_{size()}
diff --git a/mongo/include/userver/formats/bson/types.hpp b/mongo/include/userver/formats/bson/types.hpp
@@ -81,7 +81,6 @@ class Oid {
     /// @endcond
 
     bool operator==(const Oid&) const;
-    bool operator!=(const Oid&) const;
     bool operator<(const Oid&) const;
     bool operator>(const Oid&) const;
     bool operator<=(const Oid&) const;
diff --git a/mongo/include/userver/formats/bson/value.hpp b/mongo/include/userver/formats/bson/value.hpp
@@ -127,7 +127,6 @@ class Value {
     std::string GetPath() const;
 
     bool operator==(const Value&) const;
-    bool operator!=(const Value&) const;
 
     /// @brief Checks whether the selected element exists
     /// @note MemberMissingException is throws on nonexisting element access
diff --git a/mongo/include/userver/storages/mongo/cursor.hpp b/mongo/include/userver/storages/mongo/cursor.hpp
@@ -52,7 +52,6 @@ class Cursor {
         pointer operator->() const;
 
         bool operator==(const Iterator&) const;
-        bool operator!=(const Iterator&) const;
 
     private:
         Cursor* cursor_;
diff --git a/mongo/src/formats/bson/types.cpp b/mongo/src/formats/bson/types.cpp
@@ -71,8 +71,6 @@ const bson_oid_t* Oid::GetNative() const { return &oid_; }
 
 bool Oid::operator==(const Oid& rhs) const { return bson_oid_equal(&oid_, &rhs.oid_); }
 
-bool Oid::operator!=(const Oid& rhs) const { return !(*this == rhs); }
-
 bool Oid::operator<(const Oid& rhs) const { return bson_oid_compare(&oid_, &rhs.oid_) < 0; }
 
 bool Oid::operator>(const Oid& rhs) const { return bson_oid_compare(&oid_, &rhs.oid_) > 0; }
diff --git a/mongo/src/formats/bson/value.cpp b/mongo/src/formats/bson/value.cpp
@@ -89,7 +89,6 @@ uint32_t Value::GetSize() const { return impl_->GetSize(); }
 std::string Value::GetPath() const { return impl_->GetPath(); }
 
 bool Value::operator==(const Value& rhs) const { return *impl_ == *rhs.impl_; }
-bool Value::operator!=(const Value& rhs) const { return *impl_ != *rhs.impl_; }
 
 bool Value::IsMissing() const { return impl_->IsMissing(); }
 bool Value::IsArray() const { return impl_->IsArray(); }
diff --git a/mongo/src/formats/bson/value_impl.cpp b/mongo/src/formats/bson/value_impl.cpp
@@ -817,8 +817,6 @@ bool ValueImpl::operator==(ValueImpl& rhs) {
     return std::visit(Visitor(rhs), *parsed_ptr);
 }
 
-bool ValueImpl::operator!=(ValueImpl& rhs) { return !(*this == rhs); }
-
 void ValueImpl::CheckNotMissing() const {
     if (Type() == BSON_TYPE_EOD) {
         throw MemberMissingException(path_.ToStringView());
diff --git a/mongo/src/formats/bson/value_impl.hpp b/mongo/src/formats/bson/value_impl.hpp
@@ -84,7 +84,6 @@ class ValueImpl {
     bool IsString() const;
 
     bool operator==(ValueImpl&);
-    bool operator!=(ValueImpl&);
 
     void EnsureParsed();
     void SyncBsonValue();
diff --git a/mongo/src/storages/mongo/cursor.cpp b/mongo/src/storages/mongo/cursor.cpp
@@ -54,8 +54,6 @@ const formats::bson::Document* Cursor::Iterator::operator->() const { return &cu
 
 bool Cursor::Iterator::operator==(const Iterator& rhs) const { return cursor_ == rhs.cursor_; }
 
-bool Cursor::Iterator::operator!=(const Iterator& rhs) const { return !(*this == rhs); }
-
 }  // namespace storages::mongo
 
 USERVER_NAMESPACE_END
diff --git a/postgresql/include/userver/storages/postgres/detail/const_data_iterator.hpp b/postgresql/include/userver/storages/postgres/detail/const_data_iterator.hpp
@@ -81,7 +81,6 @@ class ConstDataIterator : protected DataType {
     //@{
     /** @name Iterator comparison */
     bool operator==(const Iter& rhs) const { return DoCompare(rhs) == 0; }
-    bool operator!=(const Iter& rhs) const { return !(*this == rhs); }
 
     bool operator<(const Iter& rhs) const { return DoCompare(rhs) < 0; }
     bool operator<=(const Iter& rhs) const { return DoCompare(rhs) <= 0; }
diff --git a/postgresql/include/userver/storages/postgres/detail/typed_rows.hpp b/postgresql/include/userver/storages/postgres/detail/typed_rows.hpp
@@ -75,7 +75,7 @@ class ConstTypedRowIterator : private Row {
     }
 
     ConstTypedRowIterator operator[](difference_type index) const {
-        return *this + index * static_cast<int>(Direction);
+        return *this + (index * static_cast<int>(Direction));
     }
 
     ConstTypedRowIterator& operator+=(difference_type distance) { return DoAdvance(distance); }
@@ -86,8 +86,6 @@ class ConstTypedRowIterator : private Row {
     /** @name Iterator comparison */
     bool operator==(const ConstTypedRowIterator& rhs) const { return this->Compare(rhs) == 0; }
 
-    bool operator!=(const ConstTypedRowIterator& rhs) const { return !(*this == rhs); }
-
     bool operator<(const ConstTypedRowIterator& rhs) const { return this->Compare(rhs) < 0; }
     bool operator<=(const ConstTypedRowIterator& rhs) const { return this->Compare(rhs) <= 0; }
     bool operator>(const ConstTypedRowIterator& rhs) const { return this->Compare(rhs) > 0; }
diff --git a/postgresql/include/userver/storages/postgres/io/array_types.hpp b/postgresql/include/userver/storages/postgres/io/array_types.hpp
@@ -505,8 +505,6 @@ class ContainerSplitter {
 
         bool operator==(const ChunkIterator& rhs) const { return current_ == rhs.current_; }
 
-        bool operator!=(const ChunkIterator& rhs) const { return !(*this == rhs); }
-
         value_type operator*() const { return {current_, NextStep()}; }
 
         ChunkIterator& operator++() {
diff --git a/postgresql/include/userver/storages/postgres/io/geometry_types.hpp b/postgresql/include/userver/storages/postgres/io/geometry_types.hpp
@@ -26,23 +26,20 @@ namespace detail {
 // and are not intended to be used as types for geometry calculations
 struct Point {
     constexpr bool operator==(const Point& rhs) const { return x == rhs.x && y == rhs.y; }
-    constexpr bool operator!=(const Point& rhs) const { return !(*this == rhs); }
 
     double x;
     double y;
 };
 
 struct LineSegment {
     constexpr bool operator==(const LineSegment& rhs) const { return ends[0] == rhs.ends[0] && ends[1] == rhs.ends[1]; }
-    constexpr bool operator!=(const LineSegment& rhs) const { return !(*this == rhs); }
 
     std::array<Point, 2> ends{};
 };
 
 // Line is stored as coefficients to equation a*x + b*y + c = 0
 struct Line {
     constexpr bool operator==(const Line& rhs) const { return a == rhs.a && b == rhs.b && c == rhs.c; }
-    constexpr bool operator!=(const Line& rhs) const { return !(*this == rhs); }
 
     double a;
     double b;
@@ -53,29 +50,25 @@ struct Box {
     constexpr bool operator==(const Box& rhs) const {
         return corners[0] == rhs.corners[0] && corners[1] == rhs.corners[1];
     }
-    constexpr bool operator!=(const Box& rhs) const { return !(*this == rhs); }
 
     std::array<Point, 2> corners{};
 };
 
 struct Path {
     bool operator==(const Path& rhs) const { return is_closed == rhs.is_closed && points == rhs.points; }
-    bool operator!=(const Path& rhs) const { return !(*this == rhs); }
 
     bool is_closed{false};
     std::vector<Point> points;
 };
 
 struct Polygon {
     bool operator==(const Polygon& rhs) const { return points == rhs.points; }
-    bool operator!=(const Polygon& rhs) const { return !(*this == rhs); }
 
     std::vector<Point> points;
 };
 
 struct Circle {
     constexpr bool operator==(const Circle& rhs) const { return center == rhs.center && radius == rhs.radius; }
-    constexpr bool operator!=(const Circle& rhs) const { return !(*this == rhs); }
 
     Point center;
     double radius;
diff --git a/postgresql/include/userver/storages/postgres/io/interval.hpp b/postgresql/include/userver/storages/postgres/io/interval.hpp
@@ -40,7 +40,6 @@ struct Interval {
     constexpr bool operator==(const Interval& rhs) const {
         return months == rhs.months && days == rhs.days && microseconds == rhs.microseconds;
     }
-    constexpr bool operator!=(const Interval& rhs) const { return !(*this == rhs); }
 
     constexpr DurationType GetDuration() const {
         if (months != 0) {
diff --git a/postgresql/include/userver/storages/postgres/io/range_types.hpp b/postgresql/include/userver/storages/postgres/io/range_types.hpp
@@ -78,8 +78,6 @@ class Range {
 
     bool operator==(const Range& rhs) const;
 
-    bool operator!=(const Range& rhs) const { return !(*this == rhs); }
-
     bool Empty() const { return !data_; }
 
     /// Make the range empty
@@ -144,8 +142,6 @@ class Range {
             return BoundEqual(rhs, RangeBound::kLower) && BoundEqual(rhs, RangeBound::kUpper);
         }
 
-        bool operator!=(const RangeData& rhs) const { return !(*this == rhs); }
-
         bool HasBound(RangeBounds side) const;
 
         bool IsBoundIncluded(RangeBounds side) const { return HasBound(side) && (bounds & side); }
@@ -233,7 +229,6 @@ class BoundedRange {
     explicit BoundedRange(Range<U>&&);
 
     bool operator==(const BoundedRange& rhs) const;
-    bool operator!=(const BoundedRange& rhs) const { return !(*this == rhs); }
 
     const ValueType& GetLowerBound() const { return *value_.GetLowerBound(); }
     bool IsLowerBoundIncluded() const { return value_.IsLowerBoundIncluded(); }
diff --git a/postgresql/include/userver/storages/postgres/options.hpp b/postgresql/include/userver/storages/postgres/options.hpp
@@ -142,8 +142,6 @@ struct CommandControl {
         return network_timeout_ms == rhs.network_timeout_ms && statement_timeout_ms == rhs.statement_timeout_ms &&
                prepared_statements_enabled == rhs.prepared_statements_enabled;
     }
-
-    bool operator!=(const CommandControl& rhs) const { return !(*this == rhs); }
 };
 
 /// @brief storages::postgres::CommandControl that may not be set
@@ -302,8 +300,6 @@ struct ConnectionSettings {
         return !RequiresConnectionReset(rhs) && recent_errors_threshold == rhs.recent_errors_threshold;
     }
 
-    bool operator!=(const ConnectionSettings& rhs) const { return !(*this == rhs); }
-
     bool RequiresConnectionReset(const ConnectionSettings& rhs) const {
         // TODO: max_prepared_cache_size check could be relaxed
         return prepared_statements != rhs.prepared_statements || user_types != rhs.user_types ||
diff --git a/redis/include/userver/storages/redis/base.hpp b/redis/include/userver/storages/redis/base.hpp
@@ -77,8 +77,6 @@ struct MetricsSettings {
             return timings_enabled == rhs.timings_enabled && command_timings_enabled == rhs.command_timings_enabled &&
                    request_sizes_enabled == rhs.request_sizes_enabled && reply_sizes_enabled == rhs.reply_sizes_enabled;
         }
-
-        constexpr bool operator!=(const DynamicSettings& rhs) const { return !(*this == rhs); }
     };
 
     DynamicSettings dynamic_settings;
@@ -94,8 +92,6 @@ struct MetricsSettings {
 
     constexpr bool operator==(const MetricsSettings& rhs) const { return dynamic_settings == rhs.dynamic_settings; }
 
-    constexpr bool operator!=(const MetricsSettings& rhs) const { return !(*this == rhs); }
-
     bool IsTimingsEnabled() const { return dynamic_settings.timings_enabled; }
     bool IsCommandTimingsEnabled() const { return dynamic_settings.command_timings_enabled; }
     bool IsRequestSizesEnabled() const { return dynamic_settings.request_sizes_enabled; }
@@ -108,8 +104,6 @@ struct PubsubMetricsSettings {
     constexpr bool operator==(const PubsubMetricsSettings& rhs) const {
         return per_shard_stats_enabled == rhs.per_shard_stats_enabled;
     }
-
-    constexpr bool operator!=(const PubsubMetricsSettings& rhs) const { return !(*this == rhs); }
 };
 
 struct ReplicationMonitoringSettings {
diff --git a/redis/include/userver/storages/redis/reply_types.hpp b/redis/include/userver/storages/redis/reply_types.hpp
@@ -46,8 +46,6 @@ struct GeoPoint final {
     bool operator==(const GeoPoint& rhs) const {
         return std::tie(member, dist, hash, point) == std::tie(rhs.member, rhs.dist, rhs.hash, rhs.point);
     }
-
-    bool operator!=(const GeoPoint& rhs) const { return !(*this == rhs); }
 };
 
 /// @brief Data type that holds `member` and `score`.
@@ -73,8 +71,6 @@ struct MemberScore final {
     operator std::pair<const std::string, double>() && { return {std::move(member), score}; }
 
     bool operator==(const MemberScore& rhs) const { return member == rhs.member && score == rhs.score; }
-
-    bool operator!=(const MemberScore& rhs) const { return !(*this == rhs); }
 };
 
 enum class PersistReply { kKeyOrTimeoutNotFound, kTimeoutRemoved };
diff --git a/redis/include/userver/storages/redis/request.hpp b/redis/include/userver/storages/redis/request.hpp
@@ -150,8 +150,6 @@ class ScanRequest final {
 
         bool operator==(const Iterator& rhs) const { return stream_ == rhs.stream_; }
 
-        bool operator!=(const Iterator& rhs) const { return !(*this == rhs); }
-
     private:
         ScanRequest* stream_;
     };
diff --git a/redis/src/storages/redis/impl/shard.cpp b/redis/src/storages/redis/impl/shard.cpp
@@ -52,8 +52,6 @@ void ConnectionInfoInt::Connect(Redis& instance) const {
 
 bool operator==(const ConnectionInfoInt& lhs, const ConnectionInfoInt& rhs) { return lhs.Fulltext() == rhs.Fulltext(); }
 
-bool operator!=(const ConnectionInfoInt& lhs, const ConnectionInfoInt& rhs) { return !(lhs == rhs); }
-
 bool operator<(const ConnectionInfoInt& lhs, const ConnectionInfoInt& rhs) { return lhs.Fulltext() < rhs.Fulltext(); }
 
 Shard::Shard(Options options)
diff --git a/redis/src/storages/redis/impl/shard.hpp b/redis/src/storages/redis/impl/shard.hpp
@@ -48,7 +48,6 @@ class ConnectionInfoInt {
 };
 
 bool operator==(const ConnectionInfoInt&, const ConnectionInfoInt&);
-bool operator!=(const ConnectionInfoInt&, const ConnectionInfoInt&);
 bool operator<(const ConnectionInfoInt&, const ConnectionInfoInt&);
 
 using ConnInfoMap = std::map<std::string, std::vector<ConnectionInfoInt>>;
diff --git a/universal/include/userver/formats/common/items.hpp b/universal/include/userver/formats/common/items.hpp
@@ -67,8 +67,6 @@ class ItemsWrapper final {
 
         bool operator==(const Iterator& other) const { return it_ == other.it_; }
 
-        bool operator!=(const Iterator& other) const { return !(*this == other); }
-
     private:
         RawIterator it_;
     };
diff --git a/universal/include/userver/formats/json/value.hpp b/universal/include/userver/formats/json/value.hpp
@@ -131,7 +131,6 @@ class Value {
     /// @brief Compares values.
     /// @throw MemberMissingException if `*this` or `other` is missing.
     bool operator==(const Value& other) const;
-    bool operator!=(const Value& other) const;
 
     /// @brief Returns true if *this holds nothing. When `IsMissing()` returns
     /// `true` any attempt to get the actual value or iterate over *this will
diff --git a/universal/include/userver/formats/yaml/value.hpp b/universal/include/userver/formats/yaml/value.hpp
@@ -110,7 +110,6 @@ class Value final {
     /// @brief Compares values.
     /// @throw MemberMissingException if `*this` or `other` is missing.
     bool operator==(const Value& other) const;
-    bool operator!=(const Value& other) const;
 
     /// @brief Returns true if *this holds nothing. When `IsMissing()` returns
     /// `true` any attempt to get the actual value or iterate over *this will
diff --git a/universal/include/userver/http/content_type.hpp b/universal/include/userver/http/content_type.hpp
diff --git a/universal/include/userver/utils/bytes_per_second.hpp b/universal/include/userver/utils/bytes_per_second.hpp
diff --git a/universal/include/userver/utils/default_dict.hpp b/universal/include/userver/utils/default_dict.hpp
diff --git a/universal/include/userver/utils/ip.hpp b/universal/include/userver/utils/ip.hpp
diff --git a/universal/include/userver/utils/macaddr.hpp b/universal/include/userver/utils/macaddr.hpp
diff --git a/universal/include/userver/utils/shared_readable_ptr.hpp b/universal/include/userver/utils/shared_readable_ptr.hpp
diff --git a/universal/include/userver/utils/statistics/histogram_view.hpp b/universal/include/userver/utils/statistics/histogram_view.hpp
diff --git a/universal/include/userver/utils/statistics/labels.hpp b/universal/include/userver/utils/statistics/labels.hpp
diff --git a/universal/include/userver/utils/statistics/rate.hpp b/universal/include/userver/utils/statistics/rate.hpp
diff --git a/universal/src/formats/json/value.cpp b/universal/src/formats/json/value.cpp
diff --git a/universal/src/formats/yaml/value.cpp b/universal/src/formats/yaml/value.cpp
diff --git a/universal/src/http/content_type.cpp b/universal/src/http/content_type.cpp
diff --git a/universal/src/utils/statistics/labels.cpp b/universal/src/utils/statistics/labels.cpp

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,6 @@ bool DynamicConfig::operator==(const DynamicConfig& other) const noexcept {`
`74`	`74`	`return dumps_enabled == other.dumps_enabled && min_dump_interval == other.min_dump_interval;`
`75`	`75`	`}`
`76`	`76`
`77`		`-bool DynamicConfig::operator!=(const DynamicConfig& other) const noexcept { return !(*this == other); }`
`78`		`-`
`79`	`77`	`} // namespace dump`
`80`	`78`
`81`	`79`	`USERVER_NAMESPACE_END`
Original file line number	Diff line number	Diff line change
`@@ -67,14 +67,10 @@ double HistogramView::GetTotalSum() const noexcept {`
`67`	`67`	`return total;`
`68`	`68`	`}`
`69`	`69`
`70`		`-void DumpMetric(Writer& writer, HistogramView histogram) { writer = histogram; }`
`71`		`-`
`72`	`70`	`bool operator==(HistogramView lhs, HistogramView rhs) noexcept {`
`73`	`71`	`return impl::histogram::HasSameBoundsAndValues(lhs, rhs);`
`74`	`72`	`}`
`75`	`73`
`76`		`-bool operator!=(HistogramView lhs, HistogramView rhs) noexcept { return !(lhs == rhs); }`
`77`		`-`
`78`	`74`	`} // namespace utils::statistics`
`79`	`75`
`80`	`76`	`USERVER_NAMESPACE_END`
Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,6 @@ bool TaskId::operator==(const TaskId& other) const {`
`102`	`102`	`return created_thread_id_ == other.created_thread_id_ && thread_local_counter_ == other.thread_local_counter_;`
`103`	`103`	`}`
`104`	`104`
`105`		`-bool TaskId::operator!=(const TaskId& other) const { return !(*this == other); }`
`106`		`-`
`107`	`105`	`} // namespace impl`
`108`	`106`
`109`	`107`	`TransactionLock::~TransactionLock() { Unlock(); }`
Original file line number	Diff line number	Diff line change
`@@ -68,8 +68,6 @@ bool HeadersIterator::operator==(const HeadersIterator& other) const {`
`68`	`68`	`return std::tie(headers_, index_) == std::tie(other.headers_, other.index_);`
`69`	`69`	`}`
`70`	`70`
`71`		`-bool HeadersIterator::operator!=(const HeadersIterator& other) const { return !(*this == other); }`
`72`		`-`
`73`	`71`	`HeadersReader::HeadersReader(const rd_kafka_headers_t* headers)`
`74`	`72`	`: headers_{headers},`
`75`	`73`	`size_{size()}`