fix core/server/http: fix possible HTTP server crash on shutdown in debug builds

The fix makes sure that `request_task`will not continue execution when the main task was interrupted and will not call `SetData` when `SetSendFailed`has been called already.
commit_hash:f8adf6c42076a5dcdde78d4071169d6f17356840

Author: lexeyo

.mapping.json

@@ -808,6 +808,8 @@
   "core/functional_tests/graceful_shutdown/delaying_handler.hpp":"taxi/uservices/userver/core/functional_tests/graceful_shutdown/delaying_handler.hpp",
   "core/functional_tests/graceful_shutdown/main.cpp":"taxi/uservices/userver/core/functional_tests/graceful_shutdown/main.cpp",
   "core/functional_tests/graceful_shutdown/static_config.yaml":"taxi/uservices/userver/core/functional_tests/graceful_shutdown/static_config.yaml",
+  "core/functional_tests/graceful_shutdown/tests-correct-shutdown/conftest.py":"taxi/uservices/userver/core/functional_tests/graceful_shutdown/tests-correct-shutdown/conftest.py",
+  "core/functional_tests/graceful_shutdown/tests-correct-shutdown/test_correct_shutdown.py":"taxi/uservices/userver/core/functional_tests/graceful_shutdown/tests-correct-shutdown/test_correct_shutdown.py",
   "core/functional_tests/graceful_shutdown/tests/conftest.py":"taxi/uservices/userver/core/functional_tests/graceful_shutdown/tests/conftest.py",
   "core/functional_tests/graceful_shutdown/tests/test_graceful_shutdown.py":"taxi/uservices/userver/core/functional_tests/graceful_shutdown/tests/test_graceful_shutdown.py",
   "core/functional_tests/http2server/CMakeLists.txt":"taxi/uservices/userver/core/functional_tests/http2server/CMakeLists.txt",

core/functional_tests/graceful_shutdown/CMakeLists.txt

@@ -5,4 +5,5 @@ add_executable(${PROJECT_NAME} ${SOURCES} "main.cpp")
 target_include_directories(${PROJECT_NAME} PRIVATE "${CMAKE_CURRENT_SOURCE_DIR}/src")
 target_link_libraries(${PROJECT_NAME} userver::core)
 
-userver_chaos_testsuite_add()
+userver_chaos_testsuite_add(TESTS_DIRECTORY tests)
+userver_chaos_testsuite_add(TESTS_DIRECTORY tests-correct-shutdown)

core/functional_tests/graceful_shutdown/tests-correct-shutdown/conftest.py

@@ -0,0 +1 @@
+pytest_plugins = ['pytest_userver.plugins.core']

core/functional_tests/graceful_shutdown/tests-correct-shutdown/test_correct_shutdown.py

@@ -0,0 +1,29 @@
+import asyncio
+from signal import SIGTERM
+
+import aiohttp
+import pytest
+import pytest_userver.utils.sync as sync
+
+
+@pytest.mark.uservice_oneshot
+async def test_correct_shutdown_with_long_running_request(
+    service_daemon_instance,
+    service_client,
+):
+    # This test just checks that the server will not crash on shutdown with active long-running request
+    long_running = asyncio.create_task(service_client.get('/test?delay=10s'))
+
+    service_daemon_instance.process.send_signal(SIGTERM)
+
+    async def server_is_down():
+        try:
+            await service_client.get('/ping')
+            return False
+        except aiohttp.ClientError:
+            return True
+
+    await sync.wait(server_is_down)
+
+    with pytest.raises(aiohttp.ClientError):
+        await long_running

core/src/server/net/connection_base.cpp

@@ -191,6 +191,7 @@ engine::TaskWithResult<void> ConnectionBase::HandleQueueItem(const std::shared_p
         }
     } catch (const engine::WaitInterruptedException&) {
         LOG_DEBUG() << "Request processing interrupted";
+        request_task.SyncCancel();
         is_response_chain_valid_ = false;
     } catch (const std::exception& e) {
         LOG_WARNING() << "Request failed with unhandled exception: " << e;

core/src/server/request/response_base.cpp

@@ -78,6 +78,7 @@ ResponseBase::~ResponseBase() noexcept {
 }
 
 void ResponseBase::SetData(std::string data) {
+    UASSERT(!is_sent_);
     create_time_ = std::chrono::steady_clock::now();
     data_ = std::move(data);
     guard_.emplace(accounter_, create_time_, data_.size());