Skip to content

Commit 196fb4c

Browse files
higuoxingtuhaihe
authored andcommitted
Fix flaky test cases. NFC. (#110)
1 parent 0b45cff commit 196fb4c

2 files changed

Lines changed: 15 additions & 25 deletions

File tree

gpcontrib/diskquota/tests/regress/expected/test_uncommitted_table_size.out

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -110,16 +110,11 @@ SELECT pg_sleep(5);
110110

111111
(1 row)
112112

113-
SELECT tableid::regclass, size, segid FROM diskquota.table_size WHERE tableid = 'ao'::regclass and segid = -1;
114-
tableid | size | segid
115-
---------+---------+-------
116-
ao | 1263784 | -1
117-
(1 row)
118-
119-
SELECT pg_table_size('ao');
120-
pg_table_size
121-
---------------
122-
1263784
113+
SELECT (SELECT size FROM diskquota.table_size WHERE tableid = 'ao'::regclass and segid = -1)=
114+
(SELECT pg_table_size('ao'));
115+
?column?
116+
----------
117+
t
123118
(1 row)
124119

125120
commit;
@@ -157,16 +152,11 @@ SELECT pg_sleep(5);
157152

158153
(1 row)
159154

160-
SELECT tableid::regclass, size, segid FROM diskquota.table_size WHERE tableid = 'ao'::regclass and segid = -1;
161-
tableid | size | segid
162-
---------+--------+-------
163-
ao | 329576 | -1
164-
(1 row)
165-
166-
SELECT pg_table_size('ao');
167-
pg_table_size
168-
---------------
169-
329576
155+
SELECT (SELECT size FROM diskquota.table_size WHERE tableid = 'ao'::regclass and segid = -1)=
156+
(SELECT pg_table_size('ao'));
157+
?column?
158+
----------
159+
t
170160
(1 row)
171161

172162
commit;

gpcontrib/diskquota/tests/regress/sql/test_uncommitted_table_size.sql

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ begin;
4444
CREATE TABLE ao (i int) WITH (appendonly=true);
4545
INSERT INTO ao SELECT generate_series(1, 100000);
4646
SELECT pg_sleep(5);
47-
SELECT tableid::regclass, size, segid FROM diskquota.table_size WHERE tableid = 'ao'::regclass and segid = -1;
48-
SELECT pg_table_size('ao');
47+
SELECT (SELECT size FROM diskquota.table_size WHERE tableid = 'ao'::regclass and segid = -1)=
48+
(SELECT pg_table_size('ao'));
4949
commit;
5050

5151
-- AO table index
@@ -62,8 +62,8 @@ DROP TABLE ao;
6262
begin;
6363
CREATE TABLE ao WITH(appendonly=true) AS SELECT generate_series(1, 10000);
6464
SELECT pg_sleep(5);
65-
SELECT tableid::regclass, size, segid FROM diskquota.table_size WHERE tableid = 'ao'::regclass and segid = -1;
66-
SELECT pg_table_size('ao');
65+
SELECT (SELECT size FROM diskquota.table_size WHERE tableid = 'ao'::regclass and segid = -1)=
66+
(SELECT pg_table_size('ao'));
6767
commit;
6868
DROP TABLE ao;
6969

@@ -93,4 +93,4 @@ SELECT pg_sleep(5);
9393
SELECT tableid::regclass, size, segid FROM diskquota.table_size WHERE tableid = 'aocs'::regclass and segid = -1;
9494
SELECT pg_table_size('aocs');
9595
commit;
96-
DROP TABLE aocs;
96+
DROP TABLE aocs;

0 commit comments

Comments
 (0)