Fix lints

Author: aapoalas

Cargo.toml

@@ -22,7 +22,7 @@ console = "=0.16.3"
 ctrlc = "=3.5.2"
 ecmascript_atomics = { version = "=0.2.3" }
 fast-float = "=0.2.0"
-hashbrown = "=0.17.0"
+hashbrown = "=0.17.1"
 lexical = { version = "=7.0.5", default-features = false, features = [
     "std",
     "write-integers",

nova_vm/src/ecmascript/builtins/structured_data/atomics_object.rs

@@ -1503,7 +1503,7 @@ fn do_wait_critical<'gc, const IS_ASYNC: bool, const IS_I64: bool>(
             let (new_guard, timeout) = waiter_record.wait_timeout(guard, dur);
             guard = new_guard;
             if timeout.timed_out() {
-                guard.remove_from_list(byte_index_in_buffer, waiter_record);
+                guard.remove_from_list(byte_index_in_buffer, &waiter_record);
 
                 // 31. Perform LeaveCriticalSection(WL).
                 // 32. If mode is sync, return waiterRecord.[[Result]].
@@ -1645,16 +1645,15 @@ impl WaitAsyncJob {
         self.0._has_timeout
     }
 
-    /// Implementation of the Job Abstract Closure for [WaitAsyncTimeoutJob](https://tc39.es/ecma262/#sec-enqueueatomicswaitasynctimeoutjob),
+    /// Implementation of the Job Abstract Closure for
+    /// [WaitAsyncTimeoutJob](https://tc39.es/ecma262/#sec-enqueueatomicswaitasynctimeoutjob),
     /// for the cases where no timeout is specified.
-    pub(crate) fn run<'gc>(self, agent: &mut Agent, gc: GcScope<'gc, '_>) -> JsResult<'gc, ()> {
-        let gc = gc.into_nogc();
-
+    pub(crate) fn run<'gc>(self, agent: &mut Agent, gc: NoGcScope<'gc, '_>) -> JsResult<'gc, ()> {
         let waiters = get_wait_async_job_waiters(&self.0.data_block);
 
         let mut guard = waiters.lock().unwrap();
         let waiter_record = self.0.waiter_record;
-        guard.remove_from_list(self.0.byte_index_in_buffer, waiter_record.clone());
+        guard.remove_from_list(self.0.byte_index_in_buffer, &waiter_record);
 
         let result = match waiter_record.get_result() {
             Some(WaitResult::TimedOut) => WaitResult::TimedOut,
@@ -1683,24 +1682,28 @@ struct WaitAsyncTimeoutJobInner {
 pub(crate) struct WaitAsyncTimeoutJob(Box<WaitAsyncTimeoutJobInner>);
 
 impl WaitAsyncTimeoutJob {
-    pub(crate) fn run<'gc>(self, _agent: &mut Agent, _gc: GcScope<'gc, '_>) -> JsResult<'gc, ()> {
-        if self.0.waiter_record.get_result().is_some() {
-            return Ok(());
+    pub(crate) fn run<'gc>(self) {
+        let WaitAsyncTimeoutJobInner {
+            data_block,
+            byte_index_in_buffer,
+            waiter_record,
+        } = *self.0;
+        if waiter_record.get_result().is_some() {
+            return;
         }
 
-        let waiters = get_wait_async_job_waiters(&self.0.data_block);
+        let waiters = get_wait_async_job_waiters(&data_block);
         // a. Perform EnterCriticalSection(WL).
         let mut guard = waiters.lock().unwrap();
 
         // b. If WL.[[Waiters]] contains waiterRecord, then
         //         i. Let timeOfJobExecution be the time value (UTC) identifying the current time.
         //         ii. Assert: ℝ(timeOfJobExecution) ≥ waiterRecord.[[TimeoutTime]] (ignoring potential non-monotonicity of time values).
         //         iii. Set waiterRecord.[[Result]] to "timed-out".
-        self.0.waiter_record.set_result(WaitResult::TimedOut);
+        waiter_record.set_result(WaitResult::TimedOut);
 
         //         iv. Perform RemoveWaiter(WL, waiterRecord).
-        let waiter_record = self.0.waiter_record.clone();
-        guard.remove_from_list(self.0.byte_index_in_buffer, self.0.waiter_record);
+        guard.remove_from_list(byte_index_in_buffer, &waiter_record);
 
         //         v. Perform NotifyWaiter(WL, waiterRecord).
         waiter_record.notify_waiters();
@@ -1709,7 +1712,6 @@ impl WaitAsyncTimeoutJob {
         drop(guard);
 
         // d. Return unused.
-        Ok(())
     }
 }
 

nova_vm/src/ecmascript/builtins/temporal/plain_time.rs

@@ -143,7 +143,6 @@ pub(crate) fn create_temporal_plain_time<'gc>(
 /// a normal completion containing a Temporal.PlainTime or a throw completion.
 /// It adds/subtracts temporalDurationLike to/from temporalTime, returning a
 /// point in time that is in the future/past relative to temporalTime.
-/// It performs the following steps when called:
 fn add_duration_to_time<'gc, const IS_ADD: bool>(
     agent: &mut Agent,
     plan_time: TemporalPlainTime,

nova_vm/src/ecmascript/execution/agent.rs

@@ -316,9 +316,12 @@ impl Job {
             InnerJob::PromiseResolveThenable(job) => job.run(agent, gc),
             InnerJob::PromiseReaction(job) => job.run(agent, gc),
             #[cfg(feature = "atomics")]
-            InnerJob::WaitAsync(job) => job.run(agent, gc),
+            InnerJob::WaitAsync(job) => job.run(agent, gc.into_nogc()),
             #[cfg(feature = "atomics")]
-            InnerJob::WaitAsyncTimeout(job) => job.run(agent, gc),
+            InnerJob::WaitAsyncTimeout(job) => {
+                job.run();
+                Ok(())
+            }
             #[cfg(feature = "weak-refs")]
             InnerJob::FinalizationRegistry(job) => {
                 job.run(agent, gc);

nova_vm/src/ecmascript/types/spec/data_block.rs

@@ -541,12 +541,12 @@ impl WaiterList {
         self.waiters.push_back(w);
     }
 
-    pub(crate) fn remove(&mut self, w: Arc<WaiterRecord>) -> bool {
+    pub(crate) fn remove(&mut self, w: &Arc<WaiterRecord>) -> bool {
         let Some(index) = self
             .waiters
             .iter()
             .enumerate()
-            .find(|(_, e)| Arc::ptr_eq(e, &w))
+            .find(|(_, e)| Arc::ptr_eq(e, w))
             .map(|(i, _)| i)
         else {
             return false;
@@ -572,7 +572,7 @@ impl WaiterLists {
         self.map.entry(index).or_default().push(w);
     }
 
-    pub(crate) fn remove_from_list(&mut self, index: usize, w: Arc<WaiterRecord>) {
+    pub(crate) fn remove_from_list(&mut self, index: usize, w: &Arc<WaiterRecord>) {
         match self.map.entry(index) {
             Entry::Occupied(mut entry) => {
                 if entry.get_mut().remove(w) && entry.get().is_empty() {