Fix: unblanace ) (#315)

* fix ) and tests

* need to bump version for the fix

Author: tninja

HISTORY.org

@@ -3,7 +3,7 @@
 
 ** Main branch change
 
-** 1.73
+** 1.74
 - Fix: Guard eat/ghostel process filters against deleted buffers on exit and add regression tests
 - Fix: Enable ghostel full-redraw mode for Claude Code and Copilot CLI sessions
 - Refactor: Use Ghostel public API for sending input

ai-code-backends-infra-eat.el

@@ -134,18 +134,17 @@ variables for the terminal process."
           (set-process-filter
            proc
            (lambda (process output)
-             (when-let ((buf (process-buffer process)))
-               (when (buffer-live-p buf)
-                 (let ((filtered-output
-                        (with-current-buffer buf
-                          (ai-code-backends-infra--strip-alternate-screen-sequences output))))
-                   (when orig-filter
-                     (funcall orig-filter process filtered-output))
-                   (when (buffer-live-p buf)
-                     (with-current-buffer buf
-                       (when (ai-code-backends-infra--output-meaningful-p filtered-output)
-                         (ai-code-backends-infra--note-meaningful-output))
-                       (ai-code-session-link--linkify-recent-output filtered-output)))))))))))
+             (when (buffer-live-p buffer)
+               (let ((filtered-output
+                      (with-current-buffer buffer
+                        (ai-code-backends-infra--strip-alternate-screen-sequences output))))
+                 (when orig-filter
+                   (funcall orig-filter process filtered-output))
+                 (when (buffer-live-p buffer)
+                   (with-current-buffer buffer
+                     (when (ai-code-backends-infra--output-meaningful-p filtered-output)
+                       (ai-code-backends-infra--note-meaningful-output))
+                     (ai-code-session-link--linkify-recent-output filtered-output)))))))))
       (cons buffer (get-buffer-process buffer)))))
 
 (provide 'ai-code-backends-infra-eat)

ai-code-backends-infra-ghostel.el

@@ -105,20 +105,20 @@ variables for the terminal process."
       (let ((default-directory working-dir)
             (proc (ai-code-backends-infra--start-ghostel-process buffer command)))
         (when (processp proc)
-          (set-process-query-on-exit-flag proc nil)
+          (ignore-errors
+            (set-process-query-on-exit-flag proc nil))
           (let ((orig-filter (process-filter proc)))
             (set-process-filter
              proc
              (lambda (process output)
-               (when-let ((buf (process-buffer process)))
-                 (when (buffer-live-p buf)
-                   (when orig-filter
-                     (funcall orig-filter process output))
-                   (when (buffer-live-p buf)
-                     (with-current-buffer buf
-                       (when (ai-code-backends-infra--output-meaningful-p output)
-                         (ai-code-backends-infra--note-meaningful-output))
-                       (ai-code-session-link--linkify-recent-output output)))))))))
+               (when (buffer-live-p buffer)
+                 (when orig-filter
+                   (funcall orig-filter process output))
+                 (when (buffer-live-p buffer)
+                   (with-current-buffer buffer
+                     (when (ai-code-backends-infra--output-meaningful-p output)
+                       (ai-code-backends-infra--note-meaningful-output))
+                     (ai-code-session-link--linkify-recent-output output))))))))
         (cons buffer proc)))))
 
 (provide 'ai-code-backends-infra-ghostel)

ai-code-change.el

@@ -363,10 +363,13 @@ ARG is the prefix argument for clipboard context."
                                        (format "Selected region starting on line %d"
                                                region-start-line)))))
          (files-context-string (ai-code--get-context-files-string))
-         (repo-context-string (ai-code--format-repo-context-info))
+         (region-comment-block-p (or (not region-text)
+                                     (ai-code--is-comment-block region-text)))
          ;; Validate scenario before prompting user
          (_ (unless (or region-text is-comment)
               (user-error "Current line is not a TODO comment and cannot proceed with `ai-code-implement-todo'.  Please select a TODO comment (not DONE), a region of comments, or activate on a blank line")))
+         (_ (unless region-comment-block-p
+              (user-error "Selected region must be a comment block")))
          (action-intent (completing-read "Select action: "
                                          '("Code change" "Ask question")
                                          nil t))
@@ -391,16 +394,12 @@ ARG is the prefix argument for clipboard context."
          (initial-input
           (cond
            ((and ask-question-p region-text)
-            (unless (ai-code--is-comment-block region-text)
-              (user-error "Selected region must be a comment block"))
             (format "Regarding this TODO comment block in the selected region:\n%s\n%s%s%s"
                     region-location-line region-text function-context files-context-string))
            ((and ask-question-p is-comment)
             (format "Regarding this TODO comment on line %d: '%s'%s%s"
                     current-line-number current-line function-context files-context-string))
            (region-text
-            (unless (ai-code--is-comment-block region-text)
-              (user-error "Selected region must be a comment block"))
             (format
              "Please implement code for this requirement comment block in the selected region first. After implementing, keep the comment in place and ensure it begins with a DONE prefix (change TODO to DONE or prepend DONE if no prefix). If this is a pure new code block, place it after the comment; otherwise keep the existing structure and make corresponding change for the context.\n%s\n%s%s%s"
              region-location-line region-text function-context
@@ -409,6 +408,7 @@ ARG is the prefix argument for clipboard context."
             (format "Please implement code for this requirement comment on line %d: '%s' first. After implementing, keep the comment in place and ensure it begins with a DONE prefix (change TODO to DONE or prepend DONE if needed). If this is a pure new code block, place it after the comment; otherwise keep the existing structure and make corresponding change for the context.%s%s"
                     current-line-number current-line function-context files-context-string))
            (t "")))
+         (repo-context-string (ai-code--format-repo-context-info))
          (prompt (ai-code-read-string prompt-label initial-input))
          (final-prompt
           (concat prompt

ai-code.el

@@ -1,7 +1,7 @@
 ;;; ai-code.el --- Unified interface for AI coding backends such as Codex CLI, Copilot CLI, Claude Code, Gemini CLI, Opencode, Grok CLI, etc -*- lexical-binding: t; -*-
 
 ;; Author: Kang Tu <tninja@gmail.com>
-;; Version: 1.73
+;; Version: 1.74
 ;; Package-Requires: ((emacs "29.1") (transient "0.9.0") (magit "2.1.0"))
 ;; URL: https://github.com/tninja/ai-code-interface.el