fix: consume ImagePushResponse

Author: austindrenski

modules/registry/registry.go

@@ -192,15 +192,20 @@ func (c *RegistryContainer) PushImage(ctx context.Context, ref string) error {
 		return fmt.Errorf("failed to encode image auth: %w", err)
 	}
 
-	_, err = dockerCli.ImagePush(ctx, ref, client.ImagePushOptions{
+	output, err := dockerCli.ImagePush(ctx, ref, client.ImagePushOptions{
 		All:          true,
 		RegistryAuth: encodedAuth,
 	})
 	if err != nil {
 		return fmt.Errorf("push image %q: %w", ref, err)
 	}
+	defer output.Close()
+
+	if err := output.Wait(ctx); err != nil {
+		return fmt.Errorf("push image %q: %w", ref, err)
+	}
 
-	return c.ImageExists(ctx, ref)
+	return nil
 }
 
 // PullImage pulls an image from an external registry into the local Docker daemon.