Skip to content

fix error that byte could be undefined#3359

Closed
elwerene wants to merge 1 commit intotauri-apps:v2from
elwerene:byte_could_be_undefined
Closed

fix error that byte could be undefined#3359
elwerene wants to merge 1 commit intotauri-apps:v2from
elwerene:byte_could_be_undefined

Conversation

@elwerene
Copy link
Copy Markdown
Contributor

@elwerene elwerene commented Mar 24, 2026

I get this error:

vite v7.3.1 building client environment for production...
transforming (3400) node_modules/@tabler/icons-vue/dist/esm/icons/IconLayout.mjsvendor/cargo/tauri-plugin-fs-2.4.5/guest-js/index.ts:272:10 - error TS18048: 'byte' is possibly 'undefined'.

272     x += byte
             ~~~~


Found 1 error in vendor/cargo/tauri-plugin-fs-2.4.5/guest-js/index.ts:277

I don't know why typescript reports this error, but here is an easy fix for it

@elwerene elwerene requested a review from a team as a code owner March 24, 2026 12:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 24, 2026

Package Changes Through 29d6ac3

There are 14 changes which include sql with minor, sql-js with minor, deep-link with patch, deep-link-js with patch, fs with minor, fs-js with minor, http with patch, http-js with patch, updater with patch, updater-js with patch, nfc with patch, nfc-js with patch, dialog with minor, dialog-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.41 2.0.42
api-example-js 2.0.37 2.0.38
deep-link-example-js 2.2.10 2.2.11
deep-link 2.4.7 2.4.8
deep-link-js 2.4.7 2.4.8
fs 2.4.5 2.5.0
fs-js 2.4.5 2.5.0
dialog 2.6.0 2.7.0
dialog-js 2.6.0 2.7.0
http 2.5.7 2.5.8
http-js 2.5.7 2.5.8
nfc 2.3.4 2.3.5
nfc-js 2.3.4 2.3.5
persisted-scope 2.3.5 2.3.6
single-instance 2.4.0 2.4.1
sql 2.3.2 2.4.0
sql-js 2.3.2 2.4.0
updater 2.10.0 2.10.1
updater-js 2.10.0 2.10.1

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Copy link
Copy Markdown
Contributor

Legend-Master commented Mar 25, 2026

I don't think you're supposed to type check library code here, try adding skipLibCheck to your tsconfig.json

https://www.typescriptlang.org/tsconfig/#skipLibCheck

We should probably enable noUncheckedIndexedAccess in this repo though

Thanks for the PR anyways!

@elwerene
Copy link
Copy Markdown
Contributor Author

elwerene commented Mar 26, 2026

@Legend-Master skipLibCheck somehow does not help here. I'm not a Typescript expert, do you have an idea what I can use to fix this? At the moment I'm using my fork of plugins-workspace to produce releases

@Legend-Master
Copy link
Copy Markdown
Contributor

Legend-Master commented Mar 26, 2026

The error looks like it's from vite but vite usually wouldn't do the type checking at all so I'm not sure
I'll need more information on the build process to say where the problem is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elwerene @Legend-Master