feat(notification): add action listener-ready handshake with command permissions

Author: ScottMorris

plugins/notification/android/src/main/java/NotificationPlugin.kt

@@ -82,6 +82,8 @@ class NotificationPlugin(private val activity: Activity): Plugin(activity) {
   private lateinit var notificationManager: NotificationManager
   private lateinit var notificationStorage: NotificationStorage
   private var channelManager = ChannelManager(activity)
+  private val pendingActionEvents = mutableListOf<JSObject>()
+  private var isActionListenerReady = false
 
   companion object {
     var instance: NotificationPlugin? = null
@@ -96,6 +98,10 @@ class NotificationPlugin(private val activity: Activity): Plugin(activity) {
 
     super.load(webView)
     this.webView = webView
+    synchronized(this) {
+      pendingActionEvents.clear()
+      isActionListenerReady = false
+    }
     notificationStorage = NotificationStorage(activity, jsonMapper())
 
     val manager = TauriNotificationManager(
@@ -127,8 +133,18 @@ class NotificationPlugin(private val activity: Activity): Plugin(activity) {
     }
     val dataJson = manager.handleNotificationActionPerformed(intent, notificationStorage)
     if (dataJson != null) {
-      trigger("actionPerformed", dataJson)
+      dispatchActionPerformed(dataJson)
+    }
+  }
+
+  private fun dispatchActionPerformed(payload: JSObject) {
+    synchronized(this) {
+      if (!isActionListenerReady) {
+        pendingActionEvents.add(payload)
+        return
+      }
     }
+    trigger("actionPerformed", payload)
   }
 
   @Command
@@ -189,6 +205,19 @@ class NotificationPlugin(private val activity: Activity): Plugin(activity) {
     invoke.resolve()
   }
 
+  @Command
+  fun registerActionListenerReady(invoke: Invoke) {
+    val pending = JSArray()
+    synchronized(this) {
+      isActionListenerReady = true
+      for (event in pendingActionEvents) {
+        pending.put(event)
+      }
+      pendingActionEvents.clear()
+    }
+    invoke.resolveObject(pending)
+  }
+
   @SuppressLint("ObsoleteSdkInt")
   @Command
   fun getActive(invoke: Invoke) {

plugins/notification/api-iife.js

@@ -8,6 +8,7 @@ const COMMANDS: &[&str] = &[
     "is_permission_granted",
     "register_action_types",
     "register_listener",
+    "register_action_listener_ready",
     "cancel",
     "get_pending",
     "remove_active",

plugins/notification/build.rs

@@ -576,7 +576,18 @@ async function onNotificationReceived(
 async function onAction(
   cb: (notification: ActionPerformedNotification) => void
 ): Promise<PluginListener> {
-  return await addPluginListener('notification', 'actionPerformed', cb)
+  const listener = await addPluginListener('notification', 'actionPerformed', cb)
+  try {
+    const pending = await invoke<ActionPerformedNotification[]>(
+      'plugin:notification|register_action_listener_ready'
+    )
+    for (const notification of pending) {
+      cb(notification)
+    }
+  } catch {
+    // Older plugin versions and non-Android targets may not implement this command.
+  }
+  return listener
 }
 
 export type {

plugins/notification/guest-js/index.ts

@@ -66,6 +66,19 @@ public class NotificationHandler: NSObject, NotificationHandlerProtocol {
       inputValue = inputType.userText
     }
 
+    // Payload contract note:
+    // Keep this structure aligned with Android for `actionPerformed`:
+    // - `actionId`
+    // - `inputValue` (optional)
+    // - `notification` (with at least `id`, optionally `actionTypeId`)
+    //
+    // Delivery note:
+    // This event is emitted as soon as the OS callback arrives. If the JS side has
+    // not attached `onAction` yet (for example during cold start), the event may be
+    // missed. Android currently mitigates this with a pending-action queue drained
+    // by JS after listener registration.
+    //
+    // TODO: Consider applying the same queue/drain handshake on iOS for parity.
     try? self.plugin?.trigger(
       "actionPerformed",
       data: ReceivedNotification(

plugins/notification/ios/Sources/NotificationHandler.swift

@@ -0,0 +1,13 @@
+# Automatically generated - DO NOT EDIT!
+
+"$schema" = "../../schemas/schema.json"
+
+[[permission]]
+identifier = "allow-register-action-listener-ready"
+description = "Enables the register_action_listener_ready command without any pre-configured scope."
+commands.allow = ["register_action_listener_ready"]
+
+[[permission]]
+identifier = "deny-register-action-listener-ready"
+description = "Denies the register_action_listener_ready command without any pre-configured scope."
+commands.deny = ["register_action_listener_ready"]

plugins/notification/permissions/autogenerated/commands/register_action_listener_ready.toml

@@ -14,6 +14,7 @@ It allows all notification related features.
 - `allow-notify`
 - `allow-register-action-types`
 - `allow-register-listener`
+- `allow-register-action-listener-ready`
 - `allow-cancel`
 - `allow-get-pending`
 - `allow-remove-active`
@@ -324,6 +325,32 @@ Denies the permission_state command without any pre-configured scope.
 <tr>
 <td>
 
+`notification:allow-register-action-listener-ready`
+
+</td>
+<td>
+
+Enables the register_action_listener_ready command without any pre-configured scope.
+
+</td>
+</tr>
+
+<tr>
+<td>
+
+`notification:deny-register-action-listener-ready`
+
+</td>
+<td>
+
+Denies the register_action_listener_ready command without any pre-configured scope.
+
+</td>
+</tr>
+
+<tr>
+<td>
+
 `notification:allow-register-action-types`
 
 </td>

plugins/notification/permissions/autogenerated/reference.md

@@ -16,6 +16,7 @@ permissions = [
   "allow-notify",
   "allow-register-action-types",
   "allow-register-listener",
+  "allow-register-action-listener-ready",
   "allow-cancel",
   "allow-get-pending",
   "allow-remove-active",

plugins/notification/permissions/default.toml

@@ -426,6 +426,18 @@
           "const": "deny-permission-state",
           "markdownDescription": "Denies the permission_state command without any pre-configured scope."
         },
+        {
+          "description": "Enables the register_action_listener_ready command without any pre-configured scope.",
+          "type": "string",
+          "const": "allow-register-action-listener-ready",
+          "markdownDescription": "Enables the register_action_listener_ready command without any pre-configured scope."
+        },
+        {
+          "description": "Denies the register_action_listener_ready command without any pre-configured scope.",
+          "type": "string",
+          "const": "deny-register-action-listener-ready",
+          "markdownDescription": "Denies the register_action_listener_ready command without any pre-configured scope."
+        },
         {
           "description": "Enables the register_action_types command without any pre-configured scope.",
           "type": "string",
@@ -487,10 +499,10 @@
           "markdownDescription": "Denies the show command without any pre-configured scope."
         },
         {
-          "description": "This permission set configures which\nnotification features are by default exposed.\n\n#### Granted Permissions\n\nIt allows all notification related features.\n\n\n#### This default permission set includes:\n\n- `allow-is-permission-granted`\n- `allow-request-permission`\n- `allow-notify`\n- `allow-register-action-types`\n- `allow-register-listener`\n- `allow-cancel`\n- `allow-get-pending`\n- `allow-remove-active`\n- `allow-get-active`\n- `allow-check-permissions`\n- `allow-show`\n- `allow-batch`\n- `allow-list-channels`\n- `allow-delete-channel`\n- `allow-create-channel`\n- `allow-permission-state`",
+          "description": "This permission set configures which\nnotification features are by default exposed.\n\n#### Granted Permissions\n\nIt allows all notification related features.\n\n\n#### This default permission set includes:\n\n- `allow-is-permission-granted`\n- `allow-request-permission`\n- `allow-notify`\n- `allow-register-action-types`\n- `allow-register-listener`\n- `allow-register-action-listener-ready`\n- `allow-cancel`\n- `allow-get-pending`\n- `allow-remove-active`\n- `allow-get-active`\n- `allow-check-permissions`\n- `allow-show`\n- `allow-batch`\n- `allow-list-channels`\n- `allow-delete-channel`\n- `allow-create-channel`\n- `allow-permission-state`",
           "type": "string",
           "const": "default",
-          "markdownDescription": "This permission set configures which\nnotification features are by default exposed.\n\n#### Granted Permissions\n\nIt allows all notification related features.\n\n\n#### This default permission set includes:\n\n- `allow-is-permission-granted`\n- `allow-request-permission`\n- `allow-notify`\n- `allow-register-action-types`\n- `allow-register-listener`\n- `allow-cancel`\n- `allow-get-pending`\n- `allow-remove-active`\n- `allow-get-active`\n- `allow-check-permissions`\n- `allow-show`\n- `allow-batch`\n- `allow-list-channels`\n- `allow-delete-channel`\n- `allow-create-channel`\n- `allow-permission-state`"
+          "markdownDescription": "This permission set configures which\nnotification features are by default exposed.\n\n#### Granted Permissions\n\nIt allows all notification related features.\n\n\n#### This default permission set includes:\n\n- `allow-is-permission-granted`\n- `allow-request-permission`\n- `allow-notify`\n- `allow-register-action-types`\n- `allow-register-listener`\n- `allow-register-action-listener-ready`\n- `allow-cancel`\n- `allow-get-pending`\n- `allow-remove-active`\n- `allow-get-active`\n- `allow-check-permissions`\n- `allow-show`\n- `allow-batch`\n- `allow-list-channels`\n- `allow-delete-channel`\n- `allow-create-channel`\n- `allow-permission-state`"
         }
       ]
     }