[5.x] Handle 0 values in text fields and null string in slugs (#13786)

Co-authored-by: Jason Varga <jason@pixelfear.com>

Author: joshuablum

resources/js/components/slugs/Slug.js

@@ -113,7 +113,7 @@ export default class Slug {
         this.#controller = new AbortController;
 
         let aborted = false;
-        return axios.post(cp_url('slug'), payload, { signal: this.#controller.signal })
+        return axios.post(cp_url('slug'), payload, { signal: this.#controller.signal, transformResponse: [(data) => data] })
             .then(response => response.data)
             .catch(e => {
                 if (axios.isCancel(e)) {

resources/js/components/slugs/Slugify.vue

@@ -42,7 +42,7 @@ export default {
             handler() {
                 if (!this.shouldSlugify) {
                     this.slug = this.to;
-                } else if (!this.from) {
+                } else if (this.from === null || this.from === undefined || this.from === '') {
                     this.slug = '';
                 } else {
                     this.slugify();

src/Fieldtypes/Text.php

@@ -154,8 +154,10 @@ public function process($data)
 
     public function preProcessIndex($value)
     {
-        if ($value) {
-            return $this->config('prepend').$value.$this->config('append');
+        if (is_null($value)) {
+            return null;
         }
+
+        return $this->config('prepend').$value.$this->config('append');
     }
 }

tests/Feature/SlugTest.php

@@ -40,6 +40,9 @@ public static function slugProvider()
             'german characters' => ['Björn Müller', '-', 'de', 'bjoern-mueller'],
             'arabic characters' => ['صباح الخير', '-', 'ar', 'sbah-alkhyr'],
             'alternate separator' => ['one two three', '_', 'en', 'one_two_three'],
+            'null string' => ['null', '-', 'en', 'null'],
+            'zero string' => ['0', '-', 'en', '0'],
+            'false string' => ['false', '-', 'en', 'false'],
         ];
     }
 }

tests/Fieldtypes/TextTest.php

@@ -33,4 +33,29 @@ public static function processValuesProvider()
             'number' => ['number', [0, 3, 3, 3.14, null]],
         ];
     }
+
+    #[Test]
+    #[DataProvider('preProcessIndexProvider')]
+    public function it_pre_processes_index_values($config, $value, $expected)
+    {
+        $field = (new Text)->setField(new Field('test', array_merge([
+            'type' => 'text',
+        ], $config)));
+
+        $this->assertSame($expected, $field->preProcessIndex($value));
+    }
+
+    public static function preProcessIndexProvider()
+    {
+        return [
+            'string value' => [[], 'hello', 'hello'],
+            'null value' => [[], null, null],
+            'zero integer' => [[], 0, '0'],
+            'zero string' => [[], '0', '0'],
+            'zero with prepend' => [['prepend' => '$'], 0, '$0'],
+            'zero with append' => [['append' => '%'], 0, '0%'],
+            'zero with prepend and append' => [['prepend' => '$', 'append' => '%'], 0, '$0%'],
+            'string with prepend' => [['prepend' => '$'], 'hello', '$hello'],
+        ];
+    }
 }