Skip to content

Commit cd31b7d

Browse files
bnasslahsenclaude
andcommitted
ci: fix release workflow; stop tracking tsconfig.tsbuildinfo
Two problems found by a release dry run: - tsconfig.tsbuildinfo is a TypeScript incremental build cache that the frontend build rewrites, but it was committed. release:prepare refuses to run with a dirty working tree, so no release could ever complete. Untracked and ignored. - The release step now runs with -Pci,gpg. maven-release-plugin is declared inside the gpg profile, so without activating it Maven fell back to the parent's pluginManagement version (3.0.1) and ignored the plugin's configuration entirely: the tag would have been named springdoc-openapi-3.1.1 instead of v3.1.1, autoVersionSubmodules would not apply, and release:perform would have deployed unsigned artifacts that Central rejects. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 1e9e751 commit cd31b7d

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,14 @@ jobs:
7272
- name: Test
7373
run: mvn $MAVEN_ARGS -Pci -T1C test
7474

75+
# -Pgpg is required, not optional: maven-release-plugin is declared inside
76+
# the gpg profile, so without it the plugin falls back to the parent's
77+
# pluginManagement version and none of its configuration applies —
78+
# wrong tag name, no autoVersionSubmodules, and release:perform would
79+
# deploy unsigned artifacts that Central rejects.
7580
- name: Release
7681
run: |
77-
mvn $MAVEN_ARGS release:prepare release:perform \
82+
mvn $MAVEN_ARGS -Pci,gpg release:prepare release:perform \
7883
-DreleaseVersion='${{ inputs.releaseVersion }}' \
7984
-DdevelopmentVersion='${{ inputs.developmentVersion }}' \
8085
-DdryRun=${{ inputs.dryRun }} \
@@ -87,4 +92,4 @@ jobs:
8792

8893
- name: Clean up a dry run
8994
if: ${{ inputs.dryRun }}
90-
run: mvn $MAVEN_ARGS release:clean
95+
run: mvn $MAVEN_ARGS -Pci,gpg release:clean

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,3 +147,6 @@ Desktop.ini
147147
/CLAUDE.md
148148
/.claude/
149149
/default.profraw
150+
151+
# TypeScript incremental build cache
152+
*.tsbuildinfo

springdoc-openapi-starter-common-mcp/src/main/frontend/tsconfig.tsbuildinfo

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)