Frontend Upgrade

[jordisala1991]

Feature Request

After integrating with Webpack Encore and moving all our dependencies from Bower to NPM, we can start thinking on upgrading some dependencies. This will probably we against 5.0 of SonataAdmin since we already have a lot of things from 3.x to 4.0.

Here is an initial list of things to consider upgrade.

• Update jQuery to v3
• Replace icheck for https://github.com/bantikyan/icheck-bootstrap

Upgrade to Admin-lte v3

• Remove x-editable (or make it compatible with boostrap 4 or implement own solution)
• Upgrade bootstrap to v4
• Upgrade admin lte to v3 (check sandbox branch and older prs on sonata admin)

[eerison]

if we're going to upgrade bootstrap, why not bootstrap 5?

[jordisala1991]

We need to follow admin-lte route here. If admin-lte 3 is only compatible with bootstrap 4, we have to use version 4. If they release version 4 of admin-lte and it is compatible with bootstrap 5 and we want to jump 2 versions, we could do it. But that version is not there.

Note that we are on admin-lte 2 compatible with bootstrap 3, maybe jumping 2 majors is a huge amount of work or maybe not, I do not know yet.

[sarim]

AdminLTE v4 (in develop it seems) is using bootstrap 5. ColorlibHQ/AdminLTE#3692
Given that sonata admin v4 isn't released yet, its safe to assume AdminLTE v4 would be released in time for Sonata Admin v5 to use it.

[VincentLanglet]

@jordisala1991 We use

SonataAdminBundle/package.json

Line 17 in 5c5550a

"select2-bootstrap-theme": "^0.1.0-beta.10",

which only work for bootstrap 3.

If we move to boostrap 4 or 5, according to the readme of https://github.com/select2/select2, we'll have to use
https://github.com/ttskch/select2-bootstrap4-theme or https://github.com/apalfrey/select2-bootstrap-5-theme

[jordisala1991]

Yes! But at the moment the major blocker is the x editable library.

We dont want to remove the feature, but that library wont be updated anymore. So at the end we will have to remove the feature unless we want to be stuck forever. 🤷🏻‍♂️ wdyt?

[sarim]

maybe the code for inline editing can be rewritten inside sonata admin based on bootstrap "popovers" component?

[VincentLanglet]

We dont want to remove the feature, but that library wont be updated anymore. So at the end we will have to remove the feature unless we want to be stuck forever. 🤷🏻‍♂️ wdyt?

I personally never used this feature so I'm not against the removing it.
Just discovered there is a recent fork: https://github.com/skycyclone/x-editable ; but doesn't seems to be a perfect solution.

We don't have a tons of maintainers so we cannot keep everything without help. So we might use the same strategy as we're using for BlockBundle and cache, we remove it in the next major, and if wanted/possible we add a similar feature back. If someone wants to contribute in order to provide the feature without the x-editable dependency, he's more than welcomed ; but we shouldn't be blocked by this if none of the maintainers use it and we don't have contributors and only "users".

But I think @willemverspyck is using it a lot, maybe he could help us on it ?

[core23]

We don't have a tons of maintainers so we cannot keep everything without help. So we might use the same strategy as we're using for BlockBundle and cache, we remove it in the next major, and if wanted/possible we add a similar feature back. If someone wants to contribute in order to provide the feature without the x-editable dependency, he's more than welcomed ; but we shouldn't be blocked by this

👍

if none of the maintainers use it and we don't have contributors and only "users".

I'm using this feature, but it's not critical to me. After the migration to bootstrap 4 / 5, I'll have a look at this.