Skip to content

Commit ed31674

Browse files
committed
Pass dialect string (not Dialect instance) to symmetric aggregate builder
build_symmetric_aggregate_sql branches on dialect name strings like "bigquery", "postgres", etc. Passing self._dialect_instance (a Dialect object) would miss all branches and fall back to DuckDB SQL, producing invalid SQL for non-DuckDB engines.
1 parent f4fc785 commit ed31674

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sidemantic/sql/generator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1912,7 +1912,7 @@ def _build_main_select(
19121912
primary_key=pk,
19131913
agg_type=measure.agg,
19141914
model_alias=f"{model_name}_cte",
1915-
dialect=self._dialect_instance,
1915+
dialect=self.dialect,
19161916
)
19171917
else:
19181918
# Use helper that applies metric-level filters via CASE WHEN

0 commit comments

Comments
 (0)