Skip to content

Commit 3f2af1f

Browse files
committed
Make snowflake CI explicitly report fakesnow incompatibility
Instead of silently swallowing the install failure with || echo, use a separate step with continue-on-error and emit a ::warning annotation when fakesnow can't install. Tests only run when fakesnow is actually available.
1 parent db4d918 commit 3f2af1f

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

.github/workflows/integration.yml

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,25 @@ jobs:
110110
run: uv python install 3.12
111111

112112
- name: Install dependencies
113-
run: |
114-
uv sync --extra snowflake --extra dev
115-
uv pip install "fakesnow>=0.9.0" || echo "fakesnow install failed (sqlglot version mismatch), tests will be skipped"
113+
run: uv sync --extra snowflake --extra dev
114+
115+
- name: Install fakesnow
116+
id: fakesnow
117+
continue-on-error: true
118+
run: uv pip install "fakesnow>=0.9.0"
116119

117120
- name: Run Snowflake integration tests
121+
if: steps.fakesnow.outcome == 'success'
118122
env:
119123
SNOWFLAKE_TEST: "1"
120124
run: uv run pytest -m integration tests/db/test_snowflake_integration.py -v
121125

126+
- name: Report fakesnow incompatibility
127+
if: steps.fakesnow.outcome == 'failure'
128+
run: |
129+
echo "::warning::fakesnow could not be installed (likely sqlglot version mismatch). Snowflake integration tests were skipped."
130+
exit 0
131+
122132
clickhouse-integration:
123133
runs-on: ubuntu-latest
124134

0 commit comments

Comments
 (0)