Merge pull request #7 from bvolpato-dd/bv/code-changes-toggle

macos: make diff sidebar button a visual toggle

Author: nicosuave

macos/Sources/Features/Terminal/TerminalController.swift

@@ -1850,13 +1850,19 @@ class TerminalController: BaseTerminalController, TabGroupCloseCoordinator.Contr
             )
             if let window = window as? TerminalWindow {
                 window.titlebarFont = lastTitlebarFont
+                window.setDiffSidebarButtonState(willShow)
             }
         }
     }
 
     @objc func closeGitDiff(_ sender: Any?) {
         guard #available(macOS 26.0, *) else { return }
-        Task { await gitDiffSidebarState.setVisible(false, cwd: nil) }
+        Task {
+            await gitDiffSidebarState.setVisible(false, cwd: nil)
+            if let window = window as? TerminalWindow {
+                window.setDiffSidebarButtonState(false)
+            }
+        }
     }
 
     @objc func openInEditor(_ sender: Any?) {

macos/Sources/Features/Terminal/Window Styles/TerminalWindow.swift

@@ -178,7 +178,7 @@ class TerminalWindow: NSWindow {
             button.controlSize = .large
             button.target = terminalController
             button.action = #selector(TerminalController.toggleGitDiffSidebar(_:))
-            button.setButtonType(.momentaryPushIn)
+            button.setButtonType(.pushOnPushOff)
 
             container.addSubview(button)
             NSLayoutConstraint.activate([
@@ -452,6 +452,13 @@ class TerminalWindow: NSWindow {
         return label
     }()
 
+    // MARK: Diff Sidebar Toggle
+
+    /// Update the diff sidebar toggle button to reflect visibility state.
+    func setDiffSidebarButtonState(_ isOn: Bool) {
+        diffSidebarButton?.state = isOn ? .on : .off
+    }
+
     // MARK: Surface Zoom
 
     /// Set to true if a surface is currently zoomed to show the reset zoom button.