--threads accepts unsatisfiable values and panics or aborts during channel allocation and thread creation #2078

fd --threads N (-j N) parses N into an unbounded NonZeroUsize (src/cli.rs:556) and subsequently uses it to:

1. construct a channel with capacity 2 * threads; and
2. create threads execution workers when non-batched --exec / -x is used.

Excessive but syntactically valid values therefore cause allocation or thread-creation failures to surface as panics or process aborts rather than normal user-facing errors:

Reproduction 1: channel-capacity failure

The results channel is created using twice the requested thread count (src/walk.rs:636):

let (tx, rx) = bounded(2 * config.threads); 

On a 64-bit release build:

$ fd -j 9223372036854775807 .
thread 'main' panicked at alloc/src/raw_vec/mod.rs:28:5:
capacity overflow

$ echo $?
101

And under an -C overflow-checks=on build, the 2 * config.threads itself panics first (attempt to multiply with overflow, walk.rs:636) once N > usize::MAX / 2.

For a smaller but still enormous value, the capacity can be representable while the underlying allocation is not satisfiable:

$ fd -j 99999999999999 .
memory allocation of 3199999999999968 bytes failed

$ echo $?
134

Reproduction 2: execution-worker thread exhaustion

When non-batched --exec is enabled, fd creates execution workers according to the requested thread count (src/walk.rs:425):

for _ in 0..threads {
    let handle = scope.spawn(|| exec::job(/* ... */));
    // ...
}

Scope::spawn unwraps the OS thread-creation result, so once the OS refuses (EAGAIN / RLIMIT_NPROC, typically well under a million threads) it panics instead of degrading gracefully.

$ fd -j 200000 -x echo .
thread 'main' panicked at std/src/thread/scoped.rs:206:46:
failed to spawn thread: Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }
$ echo $?
134

This is primarily a robustness and availability issue. An accidental, generated, or otherwise excessive --threads value can cause fd to panic or abort instead of exiting with a controlled error.