Summary
Non-blocking follow-up from review of #3158.
While validating the node renderer fix locally, the code change itself checked out, but the Pro dummy app's manual verification path required repo-specific workarounds. That makes startup/SSR fixes harder to verify than they should be.
Problems surfaced during review
-
react_on_rails_pro/spec/dummy/bin/dev did not start cleanly in this workspace.
- Under the workspace default Ruby 4.0.1, the precompile hook failed because
jbuilder expected ostruct.
- Retrying under
ruby@3.3.7 got past that, but Procfile.dev / webpack-dev-server still failed with overlay.sockPort should be a number.
-
Changes under packages/react-on-rails-pro-node-renderer/src/** were not exercised by the dummy app until the package was rebuilt.
- The dummy app runtime consumed
packages/react-on-rails-pro-node-renderer/lib/**.
- Before
pnpm --filter react-on-rails-pro-node-renderer run build, the manual repro on /stream_native_metadata and /hybrid_metadata_streaming still showed the old ReferenceError: performance is not defined failure.
- After rebuilding the package, both endpoints rendered correctly and the fix was confirmed.
Why this matters
For changes that affect startup, build, serve, or SSR behavior, the current manual validation path can make a correct fix look broken or can accidentally validate stale built artifacts instead of the reviewed source.
Proposed follow-up
- Make the Pro dummy app's default dev startup path (
bin/dev / Procfile.dev) work cleanly on the supported toolchain.
- Document or automate the rebuild step required when validating
react-on-rails-pro-node-renderer changes against the dummy app.
- Add a short manual-validation checklist for node renderer changes so reviewers can verify SSR fixes without repo-specific workaround knowledge.
Summary
Non-blocking follow-up from review of #3158.
While validating the node renderer fix locally, the code change itself checked out, but the Pro dummy app's manual verification path required repo-specific workarounds. That makes startup/SSR fixes harder to verify than they should be.
Problems surfaced during review
react_on_rails_pro/spec/dummy/bin/devdid not start cleanly in this workspace.jbuilderexpectedostruct.ruby@3.3.7got past that, butProcfile.dev/webpack-dev-serverstill failed withoverlay.sockPort should be a number.Changes under
packages/react-on-rails-pro-node-renderer/src/**were not exercised by the dummy app until the package was rebuilt.packages/react-on-rails-pro-node-renderer/lib/**.pnpm --filter react-on-rails-pro-node-renderer run build, the manual repro on/stream_native_metadataand/hybrid_metadata_streamingstill showed the oldReferenceError: performance is not definedfailure.Why this matters
For changes that affect startup, build, serve, or SSR behavior, the current manual validation path can make a correct fix look broken or can accidentally validate stale built artifacts instead of the reviewed source.
Proposed follow-up
bin/dev/Procfile.dev) work cleanly on the supported toolchain.react-on-rails-pro-node-rendererchanges against the dummy app.