Skip to content

Commit d3b546e

Browse files
justin808claude
andauthored
Remove stale Coveralls integration (#3204)
## Summary - remove the stale Coveralls badge and the dead Coveralls-only rake paths - switch repo and generator coverage support to direct `simplecov` dependencies - update the coverage docs and replace the broken README Slack invite URL so branch checks pass Closes #1692. ## Testing - bundle exec rubocop react_on_rails/Rakefile react_on_rails/Gemfile.development_dependencies react_on_rails/lib/generators/react_on_rails/dev_tests_generator.rb react_on_rails/rakelib/run_rspec.rake react_on_rails/rakelib/shakapacker_examples.rake react_on_rails/spec/react_on_rails/generators/dev_tests_generator_spec.rb react_on_rails_pro/Rakefile react_on_rails_pro/Gemfile.development_dependencies react_on_rails_pro/rakelib/run_rspec.rake - bundle exec rspec react_on_rails/spec/react_on_rails/generators/dev_tests_generator_spec.rb - bundle exec rake -T run_rspec - (cd react_on_rails_pro && bundle exec rake -T run_rspec) - bundle exec rspec react_on_rails/spec/empty_spec.rb - (cd react_on_rails_pro && bundle exec rspec spec/empty_spec.rb) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk since changes are limited to test/CI tooling and documentation, but could affect coverage reporting if any workflows still expect Coveralls tasks or binstubs. > > **Overview** > Removes the stale Coveralls integration across both OSS and Pro: drops the Coveralls badge, deletes Coveralls-only rake hooks/tasks, and removes Coveralls binstubs from dummy apps. > > Switches coverage support to direct `simplecov` dependencies (including the `dev_tests` generator and lockfiles) and updates docs to clarify that coverage reports are produced when running tests with `COVERAGE=true`. Also updates the React+Rails Slack link to the direct workspace URL. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 80c86a8. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Switched test coverage tooling from Coveralls to SimpleCov and removed Coveralls integration/hooks. * **Documentation** * Clarified coverage reports are shown only when running tests with COVERAGE=true. * Removed the Coverage Status badge and updated Slack support links to the direct workspace URL in README and docs. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 476c4fe commit d3b546e

20 files changed

Lines changed: 34 additions & 141 deletions

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ Run `rake` for testing the gem and `react_on_rails/spec/dummy`. Otherwise, the `
430430

431431
If you run `rspec` at the top level, you'll see this message: `require': cannot load such file -- rails_helper (LoadError)`
432432

433-
After running a test, you can view the coverage results SimpleCov reports by opening `coverage/index.html`.
433+
If you run tests with `COVERAGE=true`, you can view the SimpleCov report at `coverage/index.html`.
434434

435435
Turbolinks 5 is included in the test app, unless "DISABLE_TURBOLINKS" is set to YES in the environment.
436436

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
---
1010

11-
[![License](https://img.shields.io/badge/license-mit-green.svg)](LICENSE.md)[![Gem Version](https://badge.fury.io/rb/react_on_rails.svg)](https://badge.fury.io/rb/react_on_rails) [![npm version](https://badge.fury.io/js/react-on-rails.svg)](https://badge.fury.io/js/react-on-rails) [![Coverage Status](https://coveralls.io/repos/shakacode/react_on_rails/badge.svg?branch=main&service=github)](https://coveralls.io/github/shakacode/react_on_rails?branch=main) [![Gem Downloads](https://img.shields.io/gem/dt/react_on_rails)](https://rubygems.org/gems/react_on_rails)
11+
[![License](https://img.shields.io/badge/license-mit-green.svg)](LICENSE.md)[![Gem Version](https://badge.fury.io/rb/react_on_rails.svg)](https://badge.fury.io/rb/react_on_rails) [![npm version](https://badge.fury.io/js/react-on-rails.svg)](https://badge.fury.io/js/react-on-rails) [![Gem Downloads](https://img.shields.io/gem/dt/react_on_rails)](https://rubygems.org/gems/react_on_rails)
1212

1313
[![Integration Tests](https://github.com/shakacode/react_on_rails/actions/workflows/integration-tests.yml/badge.svg)](https://github.com/shakacode/react_on_rails/actions/workflows/integration-tests.yml)
1414
[![Gem Tests](https://github.com/shakacode/react_on_rails/actions/workflows/gem-tests.yml/badge.svg)](https://github.com/shakacode/react_on_rails/actions/workflows/gem-tests.yml)
@@ -115,7 +115,8 @@ Start with the docs here:
115115
- [GitHub Discussions](https://github.com/shakacode/react_on_rails/discussions)
116116
for questions
117117
- [GitHub Issues](https://github.com/shakacode/react_on_rails/issues) for bugs
118-
- [React + Rails Slack](https://invite.reactrails.com) for community chat
118+
- [React + Rails Slack](https://reactrails.slack.com) for community chat
119+
(existing members; non-members, please use GitHub Discussions above)
119120
- [Commercial support](mailto:react_on_rails@shakacode.com) for upgrades,
120121
consulting, and Pro guidance
121122
- [AI Agent User Guide](AGENTS_USER_GUIDE.md) for AI coding assistants

docs/oss/deployment/troubleshooting.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ console.log(ReactOnRails.registeredComponents());
484484
485485
- **[GitHub Issues](https://github.com/shakacode/react_on_rails/issues)** - Bug reports and feature requests
486486
- **[GitHub Discussions](https://github.com/shakacode/react_on_rails/discussions)** - Questions and help
487-
- **[React + Rails Slack](https://invite.reactrails.com)** - Real-time community support
487+
- **[React + Rails Slack](https://reactrails.slack.com)** - Real-time community support
488488
489489
### Professional support
490490

docs/oss/getting-started/common-issues.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,5 +262,5 @@ ls -la public/packs/
262262
1. **Check the detailed [Troubleshooting Guide](../deployment/troubleshooting.md)**
263263
2. **Search [GitHub Issues](https://github.com/shakacode/react_on_rails/issues)**
264264
3. **Ask in [GitHub Discussions](https://github.com/shakacode/react_on_rails/discussions)**
265-
4. **Join [React + Rails Slack](https://invite.reactrails.com)**
265+
4. **Join [React + Rails Slack](https://reactrails.slack.com)**
266266
5. **Professional support**: [react_on_rails@shakacode.com](mailto:react_on_rails@shakacode.com)

react_on_rails/Gemfile.development_dependencies

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ end
4848
group :test do
4949
gem "capybara", "~> 3.40"
5050
gem "capybara-screenshot"
51-
gem "coveralls", require: false
51+
gem "simplecov", "~> 0.16.1", require: false
5252
gem "cypress-on-rails", "~> 1.19"
5353
gem "equivalent-xml"
5454
gem "generator_spec"

react_on_rails/Gemfile.lock

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,6 @@ GEM
119119
coderay (1.1.3)
120120
concurrent-ruby (1.3.6)
121121
connection_pool (3.0.2)
122-
coveralls (0.8.23)
123-
json (>= 1.8, < 3)
124-
simplecov (~> 0.16.1)
125-
term-ansicolor (~> 1.3)
126-
thor (>= 0.19.4, < 2.0)
127-
tins (~> 1.6)
128122
crass (1.0.6)
129123
csv (3.3.5)
130124
cypress-on-rails (1.20.0)
@@ -401,17 +395,11 @@ GEM
401395
uri (>= 0.12.0)
402396
stringio (3.2.0)
403397
strscan (3.1.0)
404-
sync (0.5.0)
405-
term-ansicolor (1.8.0)
406-
tins (~> 1.0)
407398
terminal-table (3.0.2)
408399
unicode-display_width (>= 1.1.1, < 3)
409400
thor (1.5.0)
410401
tilt (2.3.0)
411402
timeout (0.6.0)
412-
tins (1.33.0)
413-
bigdecimal
414-
sync
415403
tsort (0.2.0)
416404
turbo-rails (2.0.20)
417405
actionpack (>= 7.1.0)
@@ -448,7 +436,6 @@ DEPENDENCIES
448436
bootsnap
449437
capybara (~> 3.40)
450438
capybara-screenshot
451-
coveralls
452439
cypress-on-rails (~> 1.19)
453440
debug
454441
equivalent-xml
@@ -481,6 +468,7 @@ DEPENDENCIES
481468
sdoc
482469
selenium-webdriver (= 4.9.0)
483470
shakapacker (= 9.6.1)
471+
simplecov (~> 0.16.1)
484472
spring (~> 4.0)
485473
sprockets (~> 4.0)
486474
sqlite3 (~> 1.6)

react_on_rails/Rakefile

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
tasks = %w[lint run_rspec]
77
prepare_for_ci = %w[node_package dummy_apps]
88

9-
if ENV["USE_COVERALLS"] == "TRUE"
10-
require "coveralls/rake/task"
11-
Coveralls::RakeTask.new
12-
tasks << "coveralls:push"
13-
end
14-
159
desc "Run all tests and linting"
1610
task default: tasks
1711

react_on_rails/lib/generators/react_on_rails/dev_tests_generator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def add_test_related_gems_to_gemfile
4141
gem("rspec-rails", group: :test)
4242
# NOTE: chromedriver-helper was deprecated in 2019. Modern selenium-webdriver (4.x)
4343
# and GitHub Actions have built-in driver management, so no driver helper is needed.
44-
gem("coveralls", require: false)
44+
gem("simplecov", require: false, group: :test)
4545
end
4646

4747
def replace_prerender_if_server_rendering

react_on_rails/rakelib/run_rspec.rake

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# frozen_string_literal: true
22

3-
require "coveralls/rake/task" if ENV["USE_COVERALLS"] == "TRUE"
4-
53
require "pathname"
64
require "yaml"
75

@@ -141,8 +139,6 @@ namespace :run_rspec do
141139
pinned_version_examples.each { |example_type| Rake::Task[example_type.rspec_task_name].invoke }
142140
end
143141

144-
Coveralls::RakeTask.new if ENV["USE_COVERALLS"] == "TRUE"
145-
146142
desc "run all tests no examples"
147143
task all_but_examples: %i[gem dummy_no_turbolinks dummy js_tests] do
148144
puts "Completed all RSpec tests"
@@ -209,7 +205,6 @@ def run_tests_in(dir, options = {})
209205
env_tokens = []
210206
env_tokens << options.fetch(:env_vars, "").strip unless options.fetch(:env_vars, "").strip.empty?
211207
env_tokens << "TEST_ENV_COMMAND_NAME=\"#{command_name}\""
212-
env_tokens << "COVERAGE=true" if ENV["USE_COVERALLS"]
213208

214209
env_vars = env_tokens.join(" ")
215210
command = "#{env_vars} bundle exec rspec #{rspec_args}"

react_on_rails/rakelib/shakapacker_examples.rake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ namespace :shakapacker_examples do # rubocop:disable Metrics/BlockLength
213213
# Use unbundled_sh_in_dir to ensure the generator uses the example app's
214214
# gem versions, not the parent workspace's cached bundle context.
215215
unbundled_sh_in_dir(example_type.dir, generator_commands)
216-
# Re-run bundle install since dev_tests generator adds rspec-rails and coveralls to Gemfile
216+
# Re-run bundle install since dev_tests generator adds rspec-rails and simplecov to Gemfile
217217
bundle_install_in(example_type.dir)
218218

219219
# Apply specific React version for compatibility testing examples

0 commit comments

Comments
 (0)