Commit b4cc9c8
fix(pro-dummy): address PR #3200 review nits
Apply optional cleanups from CodeRabbit and claude[bot] review:
- Replace `ndb` with `node --inspect` in `node-renderer:debug` so the
script works without a global `ndb` install. Drop the duplicated
hyphen-style `node-renderer-debug` script and update the OSS
debugging doc to point at the colon-style name.
- Use `parseInt(devServer.port, 10)` instead of `Number(devServer.port)`
in both Pro dummy and ExecJS dummy webpack development configs to
make the base-10 numeric-parse intent explicit.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 3a6a2ee commit b4cc9c8
4 files changed
Lines changed: 4 additions & 5 deletions
File tree
- docs/oss/building-features/node-renderer
- react_on_rails_pro/spec
- dummy
- config/webpack
- execjs-compatible-dummy/config/webpack
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
108 | | - | |
| 107 | + | |
109 | 108 | | |
110 | 109 | | |
111 | 110 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
0 commit comments